Skip to content

Conversation

@RoseReatherford
Copy link
Member

Updates the plugin to add more realistic testing and log transfer success and failures.

Copy link
Member

@JoshuaLavarine JoshuaLavarine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I have one question, which I've noticed here and also referenced in a thread from my PR in production_transporter.

Do you think that we need to standardize the article_id type within Editorial Manager Transfer Service? There are a few instances of str type remaining, while the majority are int type.

@RoseReatherford
Copy link
Member Author

This looks good! I have one question, which I've noticed here and also referenced in a thread from my PR in production_transporter.

Do you think that we need to standardize the article_id type within Editorial Manager Transfer Service? There are a few instances of str type remaining, while the majority are int type.

They should all be "str" as that is the proper type. I thought I got them all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants