Skip to content

Avoid interpreting path as route #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Avoid interpreting path as route #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63043e0
Verify that path can contain colon
tt Feb 25, 2025
d2763e7
Avoid interpreting path as route
tt Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/bypass/instance.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ defmodule Bypass.Instance do
use GenServer, restart: :transient

import Bypass.Utils
import Plug.Router.Utils, only: [build_path_match: 1]
import Plug.Router.Utils, only: [build_path_match: 1, split: 1]

def start_link(opts \\ []) do
GenServer.start_link(__MODULE__, [opts])
Expand Down Expand Up @@ -297,7 +297,7 @@ defmodule Bypass.Instance do
end

defp route_info(method, path, %{expectations: expectations} = _state) do
segments = build_path_match(path) |> elem(1)
segments = path |> split

route =
expectations
Expand Down
11 changes: 11 additions & 0 deletions test/bypass_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,4 +643,15 @@ defmodule BypassTest do
Bypass.open(:error)
end
end

test "path can contain colon" do
bypass = Bypass.open()

Bypass.expect(bypass, "POST", "/resources/:resource", fn conn ->
assert conn.params == %{ "resource" => ":resource" }
Plug.Conn.send_resp(conn, 200, "")
end)

assert {:ok, 200, ""} = request(bypass.port, "/resources/:resource")
end
end