Fix top_p_sampling kernel #2231
Merged
+306
−347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
There was a problem hiding this comment.
Pull request overview
This PR fixes the seed parameter type in TopPSamplingKernel implementations by changing it from int to int64_t. This improves type consistency and supports the full range of seed values, including the sentinel value -1 and larger positive seeds.
- Changed
seedparameter frominttoint64_tin two backend implementations - Ensures compatibility with internal usage where seed is converted to
uint64_tfor random number generation - Aligns with the expected interface for random seed parameters in sampling operations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| backends/npu/kernels/fusion/topp_sampling_kernel.cc | Updated seed parameter type from int to int64_t in TopPSamplingKernel function signature |
| backends/iluvatar_gpu/kernels/ernie_core/top_p_sampling_kernel.cu | Updated seed parameter type from int to int64_t in TopPSamplingKernel function signature to match internal usage with uint64_t |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
[Metax] Fix DNN-related bugs (PaddlePaddle#194)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix top_p_sampling kernel