Skip to content

UX: Always show the select panel #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

UX: Always show the select panel #997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afbd373
Modify select panel visibility
d-buchmann Aug 13, 2025
7993228
Update translations
d-buchmann Aug 13, 2025
f064e4d
Simplify reference
d-buchmann Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions assets/controllers/elements/datatables/parts_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ export default class extends DatatablesController {

const selectPanel = this.selectPanelTarget;

//Hide/Unhide panel with the selection tools
//Enable action button based on selection
if (count > 0) {
selectPanel.classList.remove('d-none');
selectPanel.querySelector('button[type="submit"]').disabled = false;
} else {
selectPanel.classList.add('d-none');
selectPanel.querySelector('button[type="submit"]').disabled = true;
}

//Update selection count text
Expand Down
6 changes: 3 additions & 3 deletions templates/components/datatables.macro.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@

<input type="hidden" name="ids" {{ stimulus_target('elements/datatables/parts', 'selectIDs') }} value="">

<div class="d-none mb-2" {{ stimulus_target('elements/datatables/parts', 'selectPanel') }}>
<div class="mb-2" {{ stimulus_target('elements/datatables/parts', 'selectPanel') }}>
{# <span id="select_count"></span> #}

<div class="input-group">
<button class="btn btn-outline-secondary" type="button" {{ stimulus_action('elements/datatables/parts', 'invertSelection')}}
title="{% trans %}part_list.action.invert_selection{% endtrans %}" ><i class="fa-solid fa-arrow-right-arrow-left"></i></button>
<span class="input-group-text">
<span class="badge bg-primary">{% trans with {'%count%': '<span ' ~ stimulus_target('elements/datatables/parts', 'selectCount') ~ '></span>'} %}part_list.action.part_count{% endtrans %}</span>
<span class="badge bg-primary">{% trans with {'%count%': '<span ' ~ stimulus_target('elements/datatables/parts', 'selectCount') ~ '>0</span>'} %}part_list.action.part_count{% endtrans %}</span>
</span>

<select class="form-select" name="action" data-controller="elements--select" {{ stimulus_action('elements/datatables/parts', 'updateTargetPicker', 'change') }}
Expand Down Expand Up @@ -79,7 +79,7 @@
{# This is left empty, as this will be filled by Javascript #}
</select>

<button type="submit" class="btn btn-primary">{% trans %}part_list.action.submit{% endtrans %}</button>
<button disabled type="submit" class="btn btn-primary">{% trans %}part_list.action.submit{% endtrans %}</button>
</div>
</div>

Expand Down
2 changes: 1 addition & 1 deletion translations/messages.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9018,7 +9018,7 @@ Element 3</target>
<unit id="qKDo_nI" name="part_list.action.part_count">
<segment state="translated">
<source>part_list.action.part_count</source>
<target>%count% dílů vybráno!</target>
<target>%count% dílů vybráno</target>
</segment>
</unit>
<unit id="ssOogP5" name="company.edit.quick.website">
Expand Down
2 changes: 1 addition & 1 deletion translations/messages.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9006,7 +9006,7 @@ Element 3</target>
<unit id="gaoMsrY" name="part_list.action.part_count">
<segment state="translated">
<source>part_list.action.part_count</source>
<target>%count% Bauteile ausgewählt!</target>
<target>%count% Bauteile ausgewählt</target>
</segment>
</unit>
<unit id="FhdheZY" name="company.edit.quick.website">
Expand Down
2 changes: 1 addition & 1 deletion translations/messages.en.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9010,7 +9010,7 @@ Element 3</target>
<unit id="gaoMsrY" name="part_list.action.part_count">
<segment state="translated">
<source>part_list.action.part_count</source>
<target>%count% parts selected!</target>
<target>%count% parts selected</target>
</segment>
</unit>
<unit id="FhdheZY" name="company.edit.quick.website">
Expand Down
2 changes: 1 addition & 1 deletion translations/messages.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9009,7 +9009,7 @@ Elemento 3</target>
<unit id="gaoMsrY" name="part_list.action.part_count">
<segment state="translated">
<source>part_list.action.part_count</source>
<target>¡%count% componentes seleccionadas!</target>
<target>¡%count% componentes seleccionadas</target>
</segment>
</unit>
<unit id="FhdheZY" name="company.edit.quick.website">
Expand Down
18,202 changes: 9,101 additions & 9,101 deletions translations/messages.fr.xlf
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion translations/messages.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9011,7 +9011,7 @@ Element 3</target>
<unit id="gaoMsrY" name="part_list.action.part_count">
<segment state="translated">
<source>part_list.action.part_count</source>
<target>%count% componenti selezionati !</target>
<target>%count% componenti selezionati</target>
</segment>
</unit>
<unit id="FhdheZY" name="company.edit.quick.website">
Expand Down
2 changes: 1 addition & 1 deletion translations/messages.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9014,7 +9014,7 @@ Element 3</target>
<unit id="gaoMsrY" name="part_list.action.part_count">
<segment state="translated">
<source>part_list.action.part_count</source>
<target>Wybrano %count% części!</target>
<target>Wybrano %count% części</target>
</segment>
</unit>
<unit id="FhdheZY" name="company.edit.quick.website">
Expand Down
2 changes: 1 addition & 1 deletion translations/messages.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9018,7 +9018,7 @@
<unit id="gaoMsrY" name="part_list.action.part_count">
<segment state="translated">
<source>part_list.action.part_count</source>
<target>%count% компонентов выбрано!</target>
<target>%count% компонентов выбрано</target>
</segment>
</unit>
<unit id="FhdheZY" name="company.edit.quick.website">
Expand Down
Loading