Skip to content

Gradle upgrade #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Gradle upgrade #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f79c59b
set visibility to GONE when button is not defined
kojofosu Jun 30, 2025
0453b79
bump gradle from 7.0.2 -> 7.4.2
kojofosu Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions MaterialDialogLibrary/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ android {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
}
namespace 'dev.shreyaspatil.MaterialDialog'

}

Expand Down
2 changes: 1 addition & 1 deletion MaterialDialogLibrary/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<manifest package="dev.shreyaspatil.MaterialDialog" />
<manifest />
4 changes: 2 additions & 2 deletions MaterialDialogLibrary/src/main/java/dev/shreyaspatil/MaterialDialog/AbstractDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ protected View createView(@NonNull LayoutInflater inflater, @Nullable ViewGroup
mPositiveButton.getOnClickListener().onClick(AbstractDialog.this, BUTTON_POSITIVE)
);
} else {
mPositiveButtonView.setVisibility(View.INVISIBLE);
mPositiveButtonView.setVisibility(View.GONE);
}

// Set Negative Button
Expand All @@ -134,7 +134,7 @@ protected View createView(@NonNull LayoutInflater inflater, @Nullable ViewGroup
mNegativeButton.getOnClickListener().onClick(AbstractDialog.this, BUTTON_NEGATIVE)
);
} else {
mNegativeButtonView.setVisibility(View.INVISIBLE);
mNegativeButtonView.setVisibility(View.GONE);
}

// If Orientation is Horizontal, Hide AnimationView
Expand Down
4 changes: 2 additions & 2 deletions MaterialDialogLibrary/src/main/res/layout/layout_alert_dialog.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
<com.google.android.material.button.MaterialButton
android:id="@+id/button_negative"
style="@style/MaterialDialog.NegativeButton"
android:layout_width="0dp"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_weight="0.5"
app:iconGravity="textStart"
Expand All @@ -72,7 +72,7 @@
<com.google.android.material.button.MaterialButton
android:id="@+id/button_positive"
style="@style/MaterialDialog.PositiveButton"
android:layout_width="0dp"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_weight="0.5"
app:iconGravity="textStart"
Expand Down
3 changes: 1 addition & 2 deletions app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
package="dev.shreyaspatil.MaterialDialogExample">
xmlns:tools="http://schemas.android.com/tools">

<application
android:allowBackup="true"
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ buildscript {
mavenCentral()
}
dependencies {
classpath 'com.android.tools.build:gradle:7.0.4'
classpath 'com.android.tools.build:gradle:7.4.2'
classpath 'com.vanniktech:gradle-maven-publish-plugin:0.18.0'
}
}
Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Sat Jan 08 10:47:24 IST 2022
distributionBase=GRADLE_USER_HOME
distributionUrl=https\://services.gradle.org/distributions/gradle-7.0.2-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-bin.zip
distributionPath=wrapper/dists
zipStorePath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME