Skip to content

SIP90 Add N loss to leaching #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: SIP89-Add-N-loss-to-volatilization
Choose a base branch
from
Open

SIP90 Add N loss to leaching #178

wants to merge 9 commits into from

Conversation

@mswilburn
Copy link

@mswilburn mswilburn commented Oct 30, 2025 •
edited
Loading

Fixes #90

This PR:

  • Adds new param nLeachingFrac for leaching frac
  • Adds new flux nLeaching calc
  • Updates envi.minN with leaching loss
  • Adds test for N leaching (tests/sipnet/test_modeling/testNitrogenCycle.c)
  • Updates smoke tests, including the russell_2 smoke test

@mswilburn mswilburn marked this pull request as ready for review October 31, 2025 21:07
@mswilburn mswilburn requested review from Alomir and dlebauer October 31, 2025 21:07
@mswilburn mswilburn changed the title SIP90 add n loss to leaching SIP90 add N loss to leaching Oct 31, 2025
@mswilburn mswilburn changed the title SIP90 add N loss to leaching SIP90 Add N loss to leaching Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alomir Alomir Awaiting requested review from Alomir

@dlebauer dlebauer Awaiting requested review from dlebauer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mswilburn