fix(ui): optimize SchemaBox avoid fetch table schema when collapsed #3498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchemaBox component is used for table mapping in mirror creation flow. When component is mounted, all the schemas are collapsed. However, what is currently observed, regardless of box is collapsed, `fetchTablesForSchema` is always executed causing overhead requests being sent to API. Desired behaviour would be tables are fetched only if box is being expanded. This PR fixes it, trying to keep the functionality of reloading results when the `initialLoadOnly` prop is changed. It has a side effect of retried request if we collapse and expand box again, but I think it's an edge case. It's not a pain in most cases (it's less likely to have that many schemas it overloads API), but for my testing I had a peer source that consisted of >100 schemas.
|
|
Amogh-Bharadwaj
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SchemaBox component is used for table mapping in mirror creation flow. When component is mounted, all the schemas are collapsed. However, what is currently observed, regardless of box is collapsed,
fetchTablesForSchemais always executed causing overhead requests being sent to API.Desired behaviour would be tables are fetched only if box is being expanded. This PR fixes it, trying to keep the functionality of reloading results when the
initialLoadOnlyprop is changed. It has a side effect of retried request if we collapse and expand box again, but I think it's an edge case.It's not a pain in most cases (it's less likely to have that many schemas it overloads API), but for my testing I had a peer source that consisted of >100 schemas.