Skip to content

Conversation

sengthai
Copy link
Contributor

@sengthai sengthai commented Oct 2, 2025

Description of the Change:
Updated conditional checks to ensure correct handling of measurement changes during QNode transformations.

Related GitHub Issues:
Closes #2070

…ling of measurement changes during QNode transformations.
@sengthai sengthai marked this pull request as ready for review October 2, 2025 14:44
@PennyLaneAI PennyLaneAI deleted a comment from github-actions bot Oct 2, 2025
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v0.13.0-rc@f120f2c). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff              @@
##             v0.13.0-rc    #2081   +/-   ##
=============================================
  Coverage              ?   97.46%           
=============================================
  Files                 ?       91           
  Lines                 ?    10608           
  Branches              ?      995           
=============================================
  Hits                  ?    10339           
  Misses                ?      213           
  Partials              ?       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sengthai sengthai changed the title Refactor measurement change detection in apply_transforms function Fix measurement change detection in apply_transforms function Oct 2, 2025
@sengthai sengthai added the invalid This doesn't seem right label Oct 2, 2025
@paul0403
Copy link
Member

paul0403 commented Oct 2, 2025

Wait, what does the invalid label mean? 😲

@sengthai
Copy link
Contributor Author

sengthai commented Oct 2, 2025

Wait, what does the invalid label mean? 😲

@paul0403 It means the PR solution is invalid. 😅
i will convert it back to draft PR

@sengthai sengthai marked this pull request as draft October 2, 2025 18:49
- Updated related tests to reflect changes in measurement handling during QNode transformations.
@sengthai sengthai removed the invalid This doesn't seem right label Oct 6, 2025
@sengthai sengthai changed the base branch from main to v0.13.0-rc October 6, 2025 22:19
@sengthai sengthai marked this pull request as ready for review October 6, 2025 22:20
Copy link
Contributor

github-actions bot commented Oct 6, 2025

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@sengthai sengthai changed the title Fix measurement change detection in apply_transforms function [WIP] Fix measurement change detection in apply_transforms function Oct 7, 2025
@sengthai sengthai requested a review from rniczh October 8, 2025 17:47
@sengthai sengthai changed the title [WIP] Fix measurement change detection in apply_transforms function Fix measurement change detection in apply_transforms function Oct 8, 2025
Copy link
Contributor

@rniczh rniczh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sengthai , just some minor suggestions

Copy link
Contributor

@rniczh rniczh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @sengthai

@sengthai sengthai merged commit 06cb501 into v0.13.0-rc Oct 9, 2025
38 checks passed
@sengthai sengthai deleted the fix-apply-qnode-transform branch October 9, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Compilation error when applying any Pennylane transforms after qnode

3 participants