-
Notifications
You must be signed in to change notification settings - Fork 58
Migrate the unified compiler to Catalyst #2199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Oh, the +20k lines 🤖 |
I'm not really sure what the review procedure should be for this PR. Beyond linting and updates to which modules we're referencing ( |
…neAI/catalyst into migrate-unified-compiler
…_in_dim verify methods
…neAI/catalyst into migrate-unified-compiler
Co-authored-by: David Ittah <[email protected]>
…neAI/catalyst into migrate-unified-compiler
andrijapau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes since last approval LGTM
|
for the lit failure on the check-catalyst workflow, we can add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New test setup looks good to me 👍 The only thing I would like to sort out is the changelog (could also be a follow up if needed).
I'd prefer to address that later, as this PR is blocking quite a bit of work |
dime10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🎉
Co-authored-by: David Ittah <[email protected]>
This PR migrates all source code for the unified compiler to Catalyst.
Changes:
python_interfacesubmodule tofrontend/catalyst.python_interfacesubmodule tofrontend/test/pytest.pennylane.compiler.python_compiler.utils.pyfile tofrontend/test/pytestto house data that is used by multiple test files.Remaining work:
catalyst.python_interfaceinstead ofpennylane.compiler.python_compiler.Questions for reviewers:
xdslandxdsl-jaxbe hard dependencies?Future work:
frontend/test/pytestfolder and adapting them so that they can be moved to thefrontend/test/litfolder.[sc-99039] [sc-98172]