Skip to content

Conversation

@JerryChen97
Copy link
Contributor

@JerryChen97 JerryChen97 commented Nov 18, 2025

Context:
Basically, for Catalyst, the new bump-jax-patching branch means there's no patching happenning by default anymore.
In this way, we can better separate the impact of patching, instead of causing inheritance of patching from upstream to downstream.
We could also better observe what patches are actually needed for other packages depending on Pennylane.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@JerryChen97 JerryChen97 self-assigned this Nov 18, 2025
@JerryChen97 JerryChen97 added do-not-merge wip PRs that are a Work-In-Progress labels Nov 18, 2025
@JerryChen97 JerryChen97 changed the title Pennylane Jax patcher test: bump jax to 0.7.0 [WIP] Pennylane Jax patcher test: bump jax to 0.7.0 Nov 18, 2025
@rniczh rniczh changed the base branch from main to rniczh/bump-jax-to-0.7.0 November 18, 2025 16:49
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.51%. Comparing base (b25d701) to head (01125d4).
⚠️ Report is 1 commits behind head on rniczh/bump-jax-to-0.7.0.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           rniczh/bump-jax-to-0.7.0    #2205   +/-   ##
=========================================================
  Coverage                     97.51%   97.51%           
=========================================================
  Files                            93       93           
  Lines                         10996    10996           
  Branches                       1049     1049           
=========================================================
  Hits                          10723    10723           
  Misses                          210      210           
  Partials                         63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link
Contributor

@rniczh rniczh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@JerryChen97 JerryChen97 requested a review from paul0403 November 20, 2025 15:14
@JerryChen97 JerryChen97 changed the title [WIP] Pennylane Jax patcher test: bump jax to 0.7.0 Pennylane Jax patcher test: bump jax to 0.7.0 Nov 20, 2025
@JerryChen97
Copy link
Contributor Author

By fa35f3b, I would like to see the compatibility of this new adjustment with the PL with globaly patched jax

@JerryChen97
Copy link
Contributor Author

If this round of tests pass, it proves that we can safely merge this branch into base, regardless of how Pennylane proceeds with updating the patching strategy @rniczh @paul0403

@JerryChen97 JerryChen97 removed do-not-merge wip PRs that are a Work-In-Progress labels Nov 21, 2025
@JerryChen97 JerryChen97 merged commit 7793fcd into rniczh/bump-jax-to-0.7.0 Nov 21, 2025
34 checks passed
@JerryChen97 JerryChen97 deleted the yushao/bump-jax-to-0.7.0 branch November 21, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants