-
Notifications
You must be signed in to change notification settings - Fork 57
Pennylane Jax patcher test: bump jax to 0.7.0 #2205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pennylane Jax patcher test: bump jax to 0.7.0 #2205
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rniczh/bump-jax-to-0.7.0 #2205 +/- ##
=========================================================
Coverage 97.51% 97.51%
=========================================================
Files 93 93
Lines 10996 10996
Branches 1049 1049
=========================================================
Hits 10723 10723
Misses 210 210
Partials 63 63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hello. You may have forgotten to update the changelog!
|
rniczh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
|
By fa35f3b, I would like to see the compatibility of this new adjustment with the PL with globaly patched jax |
Context:
Basically, for Catalyst, the new
bump-jax-patchingbranch means there's no patching happenning by default anymore.In this way, we can better separate the impact of patching, instead of causing inheritance of patching from upstream to downstream.
We could also better observe what patches are actually needed for other packages depending on Pennylane.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: