-
Notifications
You must be signed in to change notification settings - Fork 57
Support multiple executions for runtime resource tracking #2219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…o multiple-exec workloads can be tracked
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2219 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 93 93
Lines 10886 10890 +4
Branches 1038 1038
=======================================
+ Hits 10613 10617 +4
Misses 211 211
Partials 62 62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mlxd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No notes from me --- thanks @jzaia18
I'll leave approval to others
Co-authored-by: Paul <[email protected]>
multiphaseCFD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jzaia18 . LGTM.
paul0403
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good from my side, just pending resolution of Shuli's comments 👍
multiphaseCFD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! Thanks @jzaia18 !
Context:
Runtime resource tracking currently writes out resource data at the moment that all allocated qubits are released. This causes issues when executing functions that allocate and deallocate multiple times, such as this illustrative example:
Description of the Change:
Updates
NullQubitto instead write out resource information in its destructor, ensuring all resource data is the sum of data collected for all executions.Benefits:
Prevents crashes with an ambiguous error message, allows total resource counts to be collected from split workflows
Possible Drawbacks:
The aggregated data is not possible to disaggregate if this would be desired in the future.
Related GitHub Issues:
[sc-104344]