PSMDB-1776: Adding Kerberos Docker Role #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithquinnpercona
requested review from
olexandr-havryliak and
sandraromanchenko
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR migrates Kerberos authentication setup from a system-level installation to a Docker-based approach, improving portability and isolation. The changes also improve Vault health checking and fix minor formatting issues.
- Replaces the
kerberosrole with a newkerberos-dockerrole that runs Kerberos KDC in a container - Updates Vault startup to use health endpoint polling instead of TCP port checks
- Updates all Kerberos-related test commands to execute within the Docker container
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| roles/kmip-vault/tasks/main.yml | Adds api_addr to Vault config and replaces port wait with health endpoint polling |
| roles/kerberos-docker/templates/krb5.conf | New Kerberos configuration template for the Docker-based setup |
| roles/kerberos-docker/tasks/main.yml | New main tasks file for Docker-based Kerberos deployment |
| roles/kerberos-docker/tasks/RedHat.yml | RedHat-specific dependencies for Docker-based Kerberos |
| roles/kerberos-docker/tasks/Debian.yml | Debian-specific dependencies for Docker-based Kerberos |
| psmdb/psmdb/tests/test_psmdb_install.py | Updates Kerberos principal creation to use Docker container |
| psmdb/psmdb/playbooks/playbook.yml | Switches from kerberos to kerberos-docker role |
| psmdb-tarball/psmdb-tarball/playbooks/prepare.yml | Removes trailing blank line |
| psmdb-tarball/psmdb-tarball/playbooks/playbook.yml | Switches from kerberos to kerberos-docker role |
| jstests/test_kerberos_simple.js | Updates Kerberos principal creation to use Docker container |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
olexandr-havryliak
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.