Skip to content

Maildir: avoid race conditions when email are deleted while reading #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Maildir: avoid race conditions when email are deleted while reading #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/Email/Folder/Maildir.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,15 @@ sub next_message {
my $what = $self->{_messages} || $self->_what_is_there;

my $file = shift @$what or return;

local *FILE;
open FILE, $file or croak "couldn't open '$file' for reading";
$! = 0; # reset ERRNO to ensure we only exactly test what we intend to below
unless( open FILE, $file ){
# if the file no longer exists, hand over to the next file
return $self->next_message() if $!{ENOENT};
# else complain to the user
croak "couldn't open '$file' for reading: $!";
}
join '', <FILE>;
}

Expand Down