Do not depend on insecure module Email::Address #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method Email::Address->parse is vulnerable to CVE-2015-7686 and also does not parse list of email addresses correctly. This patch replaces it by a new module Email::Address::XS. Also do not use Email::Address->parse for parsing Message-Id, In-Reply-To and References headers. They have different structure and for replying it is not needed at all. Update also unit tests for Message-Id headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method Email::Address->parse is vulnerable to CVE-2015-7686 and also does
not parse list of email addresses correctly. This patch replaces it by a
new module Email::Address::XS.
Also do not use Email::Address->parse for parsing Message-Id, In-Reply-To
and References headers. They have different structure and for replying it
is not needed at all. Update also unit tests for Message-Id headers.