Skip to content

op.c toke.c add gv_override_pvs() change manual string lit. lens to macros #23428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: blead
Choose a base branch
from
Open

op.c toke.c add gv_override_pvs() change manual string lit. lens to macros #23428

wants to merge 1 commit into from
+9 −5

Conversation

bulk88
Copy link
Contributor

@bulk88 bulk88 commented Jul 11, 2025

  • gv_override() is not exported from libperl on any OS
  • gv_overridepvs() is harder to read, gv_overrides() is an obfuscated name
  • This set of changes does not require a perldelta entry.

khwilliamson
khwilliamson requested changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@khwilliamson khwilliamson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the title, lgtm

@bulk88
op.c toke.c add gv_override_pvs() change manual string lit. lens to m…
cd48b4d 
…acros

- manually counted string lengths is an anti-pattern, even if the lengths
  are correct, there is still a thought of "what if a mistake happened"
- better tools exist in the Perl C API, this commit switches to using them
- gv_override() is not exported from libperl on any OS
- gv_overridepvs() is harder to read, gv_overrides() is an obfuscated name
@bulk88 bulk88 force-pushed the gv_override_no_finger_strlen branch from 2bdb901 to cd48b4d Compare July 18, 2025 01:29
@bulk88 bulk88 changed the title op.c toke.c add gv_override_pvs() dont count strings with a finger op.c toke.c add gv_override_pvs() change manual string lit. lens to macros Jul 18, 2025
@bulk88
Copy link
Contributor Author

bulk88 commented Jul 18, 2025

repushed with a new commit title

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khwilliamson khwilliamson khwilliamson requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bulk88 @khwilliamson