Skip to content

Conversation

@khwilliamson
Copy link
Contributor

Fixes #24018

  • This set of changes does not require a perldelta entry.

Copy link
Contributor

@Leont Leont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though it might be interesting to wait a little (like 1-2 weeks) to get a better understanding of how much of CPAN breaks because of this.

@jkeenan
Copy link
Contributor

jkeenan commented Dec 22, 2025

This pull request would resolve each of the 3 CPANtesters failures reported so far in #24018.

@jkeenan
Copy link
Contributor

jkeenan commented Jan 2, 2026

Looks good to me, though it might be interesting to wait a little (like 1-2 weeks) to get a better understanding of how much of CPAN breaks because of this.

We're not going to get an idea of CPAN breakage until we do one of two things:

  • Merge it into blead before Jan 20 and assess breakage after that day's release -- i.e., our usual approach.
  • Someone (not me!) could use Test-Against-Commit to assess impact before Jan 20.

Speaking for $self, I don't expect a lot of CPAN breakage from this p.r., so I would be content with the first approach.

@khwilliamson
Copy link
Contributor Author

@jkeenan This commit fixes CPAN breakage that was noticed by #24018, caused by 209bfe3. That commit is already in the most recent development release. It apparently isn't having any extra effect beyond the 3 already noticed.

So, @Leont, what do you suggest doing?

@Leont
Copy link
Contributor

Leont commented Jan 2, 2026

So, @Leont, what do you suggest doing?

Yeah, I think we can safely merge this :-)

@khwilliamson khwilliamson merged commit 0d10a12 into Perl:blead Jan 2, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BBC: Blead Breaks Marpa::R2

3 participants