- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 121
New 190xx Map events that are masks of existing events that used indexes as arguments #1925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
| Nightly build for this pull request: 
 This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. | 
| For a faster testing, if you are using WAE add these entries in Events.ini [EnteredByByID] [SpiedUponByID] [HouseDiscoveredByID] [DestroyedUnitsAllByID] [DestroyedBuildingsAllByID] [AllDestroyedByID] [BuiltBuildingTypeByID] [BuiltUnitTypeByID] [BuiltInfantryTypeByID] [BuiltAircraftTypeByID] [ZoneEntryByByID] [CrossesHorizontalLineByID] [CrossesVerticalLineByID] [LowPowerByID] [BuildingExistsByID] [AttackedByByID] [SpyEntersAsHouseByID] [SpyEntersAsInfantryByID] [DestroyedUnitsNavalByID] [DestroyedUnitsLandByID] [BuildingDoesNotExistByID] [PowerFullByID] [EnteredOrOverflownByByID] | 
Like in PR#1901 related to ScriptType actions I created new events that are in reality masks of the original map events that used the index as parameter but here we'll use the ID so if we'll modify the main lists in rulesmd.ini these indexes won't be necessary to be recalculated again.
Internally this just finds the index of the specified ID and then the event number is replaced with the original and the indez is passed as parameter.
I used as reference the list here:
https://modenc.renegadeprojects.com/Events/RA2YR
19001Entered By ... by ID[Countries]list instead of an index.In
mycampaign.map:19002Spied By ... by ID[Countries]list instead of an index.In
mycampaign.map:19005House Discovered ... by ID[Countries]list instead of an index.In
mycampaign.map:19009Destroyed, Units, All ... by ID[Countries]list instead of an index.In
mycampaign.map:19010Destroyed, Buildings, All ... by ID[Countries]list instead of an index.In
mycampaign.map:19011Destroyed, All ... by ID[Countries]list instead of an index.In
mycampaign.map:19019Build building type ... by ID[BuildingTypes]list instead of an index.In
mycampaign.map:19020Build unit type ... by ID[VehicleTypes]list instead of an index.In
mycampaign.map:19021Build infantry type ... by ID[InfantryTypes]list instead of an index.In
mycampaign.map:19022Build aircraft type ... by ID[AircraftTypes]list instead of an index.In
mycampaign.map:19024Zone entry by ... by ID[Countries]list instead of an index.In
mycampaign.map:19025Crosses horizontal line ... by ID[Countries]list instead of an index.In
mycampaign.map:19026Crosses vertical line ... by ID[Countries]list instead of an index.In
mycampaign.map:19030Low power ... by ID[Countries]list instead of an index.In
mycampaign.map:19032Building exists ... by ID[BuildingTypes]list instead of an index.In
mycampaign.map:19044Attacked by (house) ... by ID[Countries]list instead of an index.In
mycampaign.map:19053Spy entering as House ... by ID[Countries]list instead of an index.In
mycampaign.map:19054Spy entering as Infantry ... by ID[InfantryTypes]list instead of an index.In
mycampaign.map:19055Destroyed Units, Naval ... by ID[Countries]list instead of an index.In
mycampaign.map:19056Destroyed Units, Land ... by ID[Countries]list instead of an index.In
mycampaign.map:19057Building does not exist ... by ID[BuildingTypes]list instead of an index.In
mycampaign.map:19058Power Full ... by ID[Countries]list instead of an index.In
mycampaign.map:19059Entered or Overflown By ... by ID[Countries]list instead of an index.In
mycampaign.map: