Detector z positions #13
Merged
+49
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tobias-boeckh
commented
Dec 9, 2025
tobias-boeckh
commented
- Use scinitillator thickness in calculation of pixel z positions
- Add messenger for scinitillator box thickness (previously this was equal to the tungsten thickness, which does not have to be the case)
- Fix calculation of z-position of vertex
benw22022
approved these changes
Dec 9, 2025
Contributor
benw22022
left a comment
benw22022
left a comment
There was a problem hiding this comment.
Cheers @tobias-boeckh! I think GetPixelZPositions looks right. I have a couple of pedantic comments, but otherwise please feel free to merge when you're ready 🙂
Contributor
There was a problem hiding this comment.
should say # default category is mm
Contributor
There was a problem hiding this comment.
New geometry commands should be documented in README table
Contributor
Author
There was a problem hiding this comment.
Thanks @benw22022, I've updated the readme and fixed the unit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.