Implement insert and move dimension actions for Google Sheets component #18973
Conversation
- Added new actions: Insert Dimension and Move Dimension, allowing users to manipulate dimensions within spreadsheets. - Updated the Google Sheets component to version 0.10.0 to reflect these additions. - Refactored imports for better organization and clarity.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
WalkthroughAdds two new Google Sheets actions (Insert Dimension, Move Dimension), implements corresponding app methods, and updates many action/source version strings; package version bumped to 0.10.0. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Action as Action Module
participant App as Google Sheets App
participant API as Google Sheets API
User->>Action: Invoke action (sheetId, dimension, startIndex, endIndex, inheritFromBefore)
Action->>App: insertDimension(sheetId, { range: { dimension, startIndex, endIndex }, inheritFromBefore })
App->>API: POST spreadsheets.batchUpdate { requests: [ { insertDimension: { ... } } ] }
API-->>App: Response
App-->>Action: Response
Action-->>User: Summary + response
sequenceDiagram
participant User
participant Action as Action Module
participant App as Google Sheets App
participant API as Google Sheets API
User->>Action: Invoke action (sheetId, dimension, startIndex, endIndex, destinationIndex)
Action->>App: moveDimension(sheetId, { source: { dimension, startIndex, endIndex }, destinationIndex })
App->>API: POST spreadsheets.batchUpdate { requests: [ { moveDimension: { ... } } ] }
API-->>App: Response
App-->>Action: Response
Action-->>User: Summary + response
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (29)
🧰 Additional context used🧠 Learnings (3)📚 Learning: 2024-10-30T15:24:39.294ZApplied to files:
📚 Learning: 2024-10-08T15:33:38.240ZApplied to files:
📚 Learning: 2025-01-23T03:55:15.166ZApplied to files:
🧬 Code graph analysis (1)components/google_sheets/actions/move-dimension/move-dimension.mjs (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (28)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (4)
components/google_sheets/actions/insert-dimension/insert-dimension.mjs(1 hunks)components/google_sheets/actions/move-dimension/move-dimension.mjs(1 hunks)components/google_sheets/google_sheets.app.mjs(2 hunks)components/google_sheets/package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-15T22:01:11.472Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 18362
File: components/leonardo_ai/actions/generate-image/generate-image.mjs:103-105
Timestamp: 2025-09-15T22:01:11.472Z
Learning: In Pipedream components, pipedream/platform's axios implementation automatically excludes undefined values from HTTP requests, so there's no need to manually check for truthiness before including properties in request payloads.
Applied to files:
components/google_sheets/google_sheets.app.mjs
🧬 Code graph analysis (2)
components/google_sheets/actions/insert-dimension/insert-dimension.mjs (1)
components/google_sheets/actions/move-dimension/move-dimension.mjs (1)
response(63-70)
components/google_sheets/actions/move-dimension/move-dimension.mjs (1)
components/google_sheets/actions/insert-dimension/insert-dimension.mjs (1)
response(66-73)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: pnpm publish
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (4)
components/google_sheets/package.json (1)
3-3: LGTM! Appropriate version bump.The minor version increment correctly reflects the addition of new features (insert-dimension and move-dimension actions).
components/google_sheets/google_sheets.app.mjs (1)
3-7: LGTM! Modular lodash imports.Using modular lodash imports is a best practice that reduces bundle size.
components/google_sheets/actions/insert-dimension/insert-dimension.mjs (1)
8-12: Consider settingdestructiveHint: true.While inserting dimensions doesn't delete data, it does modify the spreadsheet structure by adding rows/columns, which could affect formulas, references, and layout. Consider whether
destructiveHint: truewould be more appropriate to warn users of structural changes.components/google_sheets/actions/move-dimension/move-dimension.mjs (1)
8-12: Consider settingdestructiveHint: true.Moving dimensions changes the spreadsheet structure and can affect formulas, references, and layout. Consider whether
destructiveHint: truewould be more appropriate to warn users of these structural changes.
components/google_sheets/actions/move-dimension/move-dimension.mjs
Outdated
Show resolved
Hide resolved
- Bumped version numbers for various actions, including: - Add Column (0.1.13 to 0.1.14) - Add Multiple Rows (0.2.16 to 0.2.17) - Add Single Row (2.1.19 to 2.1.20) - Clear Cell (0.1.17 to 0.1.18) - Clear Rows (0.1.15 to 0.1.16) - Copy Worksheet (0.1.13 to 0.1.14) - Create Spreadsheet (0.1.15 to 0.1.16) - Create Worksheet (0.1.13 to 0.1.14) - Delete Rows (0.0.13 to 0.0.14) - Delete Worksheet (0.1.13 to 0.1.14) - Find Row (0.2.16 to 0.2.17) - Get Cell (0.1.15 to 0.1.16) - Get Current User (0.0.1 to 0.0.2) - Get Spreadsheet by ID (0.1.14 to 0.1.15) - Get Values in Range (0.1.15 to 0.1.16) - Insert Anchored Note (0.1.13 to 0.1.14) - Insert Comment (0.1.14 to 0.1.15) - List Worksheets (0.1.13 to 0.1.14) - Update Cell (0.1.15 to 0.1.16) - Update Formatting (0.0.1 to 0.0.2) - Update Multiple Rows (0.1.15 to 0.1.16) - Update Row (0.1.17 to 0.1.18) - Upsert Row (0.1.17 to 0.1.18) - Updated version numbers for sources, including: - New Comment (0.1.2 to 0.1.3) - New Row Added (0.2.2 to 0.2.3) - New Row Added (Polling) (0.1.2 to 0.1.3) - New Updates (0.3.2 to 0.3.3) - New Worksheet (0.2.2 to 0.2.3)
….mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
jcortes
left a comment
jcortes
left a comment
There was a problem hiding this comment.
Hi @luancazarine lgtm! Ready for QA!
|
Hi everyone, all test cases are passed! Ready for release! Test reports
|
luancazarine
deleted the
18937-action-google-sheets---insert-and-move-rows-at-specific-positions
branch
Resolves #18937
Summary by CodeRabbit
New Features
Chores