Skip to content

Conversation

@chillfox
Copy link
Contributor

No description provided.

@chillfox chillfox self-assigned this Jun 11, 2025
@github-actions
Copy link

github-actions bot commented Jun 11, 2025

Hey, your PR is titled feat(booking) [PPT-1942] include parent in json.
This is not a valid conventional commit.
Since we use well-formed PR titles for our changelogs, not fixing this can introduce problems :'(

@stakach
Copy link
Member

stakach commented Jun 11, 2025

are we doing this on an index route? or just in a show route
if on the index route then we should also implement a helper function that:

  1. accepts an array of bookings
  2. finds all the ones that have a parent id
  3. makes a single query to fetch all the parent ids
  4. applies the parent object to the bookings

This way we make 2 database requests instead of N+1

@chillfox chillfox requested a review from stakach June 13, 2025 04:39
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple of minor tweaks. Looks good

@stakach stakach merged commit e4ff48d into master Jun 13, 2025
7 of 9 checks passed
@stakach stakach deleted the PPT-1942-concierge-assets-add-level-sort branch June 13, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants