feat: [PPT-2077] Added alert & dashboard models #296
Conversation
stakach
left a comment
stakach
left a comment
There was a problem hiding this comment.
One minor change related to check interval
src/placeos-models/alert.cr
Outdated
| attribute alert_type : AlertType = AlertType::THRESHOLD, converter: PlaceOS::Model::PGEnumConverter(PlaceOS::Model::Alert::AlertType) | ||
|
|
||
| # In milliseconds - how often to check the condition | ||
| attribute check_interval : Int32 = 60000 # 1 minute default |
There was a problem hiding this comment.
I don't think we need check_interval as MQTT pushes data as it changes so the frontent will be notified of any changes as soon as they occur.
Hence the conditions can be checked each time there is an update.
What might be useful is a delay on notification, like say don't show low priority issues unless they have been active for 1min without resolving automatically, 30 seconds for medium, 15 seconds for high and 2 seconds for critical (as defaults)
The user could configure alternative times - but the defaults might be simpler to be defined on the frontend and we just have the model default to 15 seconds if the frontend doesn't specify
github-actions
bot
added
type: enhancement
No description provided.