feat: [PPT-2295] zone queries to support multiple parent_ids #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
naqvis
commented
Nov 20, 2025
naqvis
commented
- fix to loki query
stakach
requested changes
Nov 20, 2025
Member
stakach
left a comment
stakach
left a comment
There was a problem hiding this comment.
Let's use converters so we have strongly typed params
| @[AC::Param::Info(description: "only return zones who have this zone as a parent (supports comma-separated list)", example: "zone-1234,zone-5678")] | ||
| parent_id : String? = nil, | ||
| @[AC::Param::Info(description: "return zones with particular tags", example: "building,level")] | ||
| tags : Array(String)? = nil, |
Member
There was a problem hiding this comment.
We should be using the converter helpers to support multiple parent_ids
@[AC::Route::GET("/", converters: {tags: ConvertStringArray, parent_id: ConvertStringArray})]
def index(
@[AC::Param::Info(description: "only return zones who have this zone as a parent (supports comma-separated list)", example: "zone-1234,zone-5678")]
parent_id : Array(String)? = nil,
Contributor
Author
There was a problem hiding this comment.
refactored that endpoint
Member
There was a problem hiding this comment.
simplified it a bit more as the converter already does some of this
github-actions
bot
added
type: enhancement
github-actions
bot
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.