Use constexpr variables if possible #5522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larshg
previously approved these changes
Nov 21, 2022
|
Found some more occurrences after I had not anymore the noise from #5525. Therefore refreshed the PR. |
larshg
previously approved these changes
Nov 24, 2022
|
@SunBlack Can you resolve the conflicts, please? |
…ed at compile time. Consider using constexpr."
larshg
approved these changes
Dec 14, 2022
mvieth
added
the
changelog: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MSVC warning C26814:
The const variable 'variable' can be computed at compile time. Consider using constexpr.