-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add OpenMP Parallelization to FarthestPointSampling #6287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+48
−11
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2b05c57
changed behavior to index into user indices instead of total pointcloud
alexnavtt 2295d0b
made index mapping lambda take auto parameter
alexnavtt 8bad843
Added parallel implementation of farthest_point_sampling
alexnavtt 7f6cff9
Added `default(none)` to the omp parallel clause
alexnavtt 7f2a4c6
Fixed first set of review comments
alexnavtt 030910f
Fixed race condition and added separate reduction section
alexnavtt c92b5d0
Renamed nr_threads_ to num_threads_
alexnavtt 193f78c
Switched num_threads_ == 0 to num_threads != 0
alexnavtt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -79,12 +79,36 @@ namespace pcl | |||||
| return (seed_); | ||||||
| } | ||||||
|
|
||||||
| /** \brief Set the number of threads to use when operating in parallel | ||||||
| * \param nr_threads the number of threads to use | ||||||
| */ | ||||||
| inline void | ||||||
| setNumberOfThreads (unsigned int nr_threads) | ||||||
| { | ||||||
| #ifdef _OPENMP | ||||||
| nr_threads_ = nr_threads == 0 ? omp_get_num_procs() : nr_threads; | ||||||
|
||||||
| nr_threads_ = nr_threads == 0 ? omp_get_num_procs() : nr_threads; | |
| nr_threads_ = nr_threads != 0 ? nr_threads : omp_get_num_procs(); |
To keep it more consistent with existing
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this one 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.