[FIX] 사진이 한장일 때 무한 스크롤을 방지하도록 수정 #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 셀에서 벗어날 때 해당 델리게이트 메서드가 동작 - 하지만 셀에 이미지가 한장일 때 해당 메서드가 out of index를 유발함 - 해당 부분을 guard문으로 처리
- 디버깅 중 확인한 부분입니다 - (홈 → 상세) 이동 후에도 홈의 배너 무한스크롤이 계속 작동하는 문제 - 홈의 무한 스크롤이 한번 시작했음에도 계속 다시 시작하는 문제
dongglehada
approved these changes
Apr 4, 2025
Member
dongglehada
left a comment
dongglehada
left a comment
There was a problem hiding this comment.
분기를 통해 수정해주셨군요! 확인 완료하였습니다
Contributor
|
분기처리를 추가하셔서 해결하시구 스크롤 종료에 가드문을 추가하셨군용! 확인하였습니다 수고하셨어요!! |
zzangzzangguy
approved these changes
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 이슈
✅ 작업 사항
ImageBannerSectionCell.swift파일의inject()메서드 수정ImageBannerSectionCell.swift파일의collectionView(), didEndDisplaying델리게이트 메서드 수정🚀 테스트 방식