-
Notifications
You must be signed in to change notification settings - Fork 0
REAFACTOR: Domain Layer DTO 제거 #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zzangzzangguy
merged 12 commits into
refactor/#112-Modulization
from
refactor/#117-remove-dtos-domain-layer
Apr 20, 2025
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8be3180
refactor/#117: Admin 도메인 레이어 DTO 제거 및 Params 객체 적용
zzangzzangguy 0d32c26
refactor/#117: Map API 관련 DTO제거 빌드테스트 확인
zzangzzangguy 22a0571
refactor/#117: MapPopUpStore 도메인 모델에서 프레임워크 의존성 제거
zzangzzangguy 9edf785
refactor/#117: DTO -> 도메인 모델 변환 로직을 MapDomainModelConverter로 분리
zzangzzangguy 0e85d9b
refactor/#117: Auth API DomainLayer DTO 제거 빌드확인
zzangzzangguy 1f4ce48
refactor/#117: Comment API 레포지토리 인터페이스에서 DTO 파라미터 제거 및 임플에서 매핑 빌드테스트 확인
zzangzzangguy ca1ddb7
style/#117: Apply SwiftLint autocorrect
github-actions[bot] 49fd01b
Merge branch 'refactor/#112-Modulization' into refactor/#117-remove-d…
zzangzzangguy ab5403d
Merge branch 'refactor/#112-Modulization' of https://github.com/PopPo…
zzangzzangguy 7c88129
Merge branch 'refactor/#117-remove-dtos-domain-layer' of https://gith…
zzangzzangguy 0eb1045
refactor/#117: AdminVC DTO사용 제거 , Params 스타일에 맞도록 네이밍 변경
zzangzzangguy 11a8620
refactor/#117: 팝업레지스터 뷰컨에서 DTO 제거 빌드테스트 확인
zzangzzangguy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
Poppool/Poppool/DataLayer/Network/API/AdminAPI/AdminAPIEndpoint.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| import Foundation | ||
|
|
||
| struct EmptyResponse: Decodable {} | ||
|
|
||
| struct AdminAPIEndpoint { | ||
|
|
||
| // MARK: - Store List | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
임포트 순서가 퍼스트 파티, 서드 파티 순서로 배치되어 있으면 좋을 것 같습니다.