Skip to content

[REFACTOR] Kingfisher 기능을 대체하기 위한 ImageLoader 개발 #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dongglehada merged 12 commits into from
Apr 8, 2025
Merged

[REFACTOR] Kingfisher 기능을 대체하기 위한 ImageLoader 개발 #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3e50213
feat/#92: URL을 사용한 이미지 다운로드 기능 초기 구현
dongglehada Mar 31, 2025
ae607ab
Merge branch 'dev' of https://github.com/PopPool/iOS-renew into refac…
dongglehada Mar 31, 2025
c3ad17a
feat/#92: NSCache 적용
dongglehada Mar 31, 2025
42d4a95
feat/#92: 메모리 캐시 스토리지 분리 및 자동 캐시 데이터 제거 로직 적용 및 문서화
dongglehada Mar 31, 2025
395729f
feat/#92: DiskStorage 적용
dongglehada Apr 1, 2025
b529e24
feat/#92: 이미지 리사이징 적용
dongglehada Apr 1, 2025
6db82d3
refactor/#92: Kingfisher 제거 및 관련 코드 제거, 대치
dongglehada Apr 6, 2025
d80a512
fix/#92: DiskStorage TImer 삭제
dongglehada Apr 6, 2025
808b414
Merge branch 'dev' of https://github.com/PopPool/iOS-renew into refac…
dongglehada Apr 7, 2025
72b9de6
refactor/#92: import Kingfisher 제거 및 빌드 가능하게 코드 일부 수정
dongglehada Apr 7, 2025
8b2674e
refactor/#92: import Kingfisher 제거
dongglehada Apr 7, 2025
ec1848b
style/#92: Apply SwiftLint autocorrect
github-actions[bot] Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 21 additions & 17 deletions Poppool/Poppool.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,8 @@
0899526E2D0474340022AEF9 /* GetSearchPopUpListResponse.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0899526D2D0474340022AEF9 /* GetSearchPopUpListResponse.swift */; };
089952732D0475E90022AEF9 /* SearchResultCountSection.swift in Sources */ = {isa = PBXBuildFile; fileRef = 089952722D0475E90022AEF9 /* SearchResultCountSection.swift */; };
089952752D0475F20022AEF9 /* SearchResultCountSectionCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 089952742D0475F20022AEF9 /* SearchResultCountSectionCell.swift */; };
089B4FD82D9A57AE00FC0CC3 /* ImageLoader.swift in Sources */ = {isa = PBXBuildFile; fileRef = 089B4FD72D9A57AE00FC0CC3 /* ImageLoader.swift */; };
089B4FDF2D9A8F9A00FC0CC3 /* MemoryStorage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 089B4FDE2D9A8F9A00FC0CC3 /* MemoryStorage.swift */; };
08A2E46C2D15BC5000102313 /* CommentLikeRequestDTO.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08A2E46B2D15BC5000102313 /* CommentLikeRequestDTO.swift */; };
08A2E4792D1B06A300102313 /* ImageDetailView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08A2E4782D1B06A300102313 /* ImageDetailView.swift */; };
08A2E47B2D1B06AA00102313 /* ImageDetailController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08A2E47A2D1B06AA00102313 /* ImageDetailController.swift */; };
Expand Down Expand Up @@ -343,6 +345,7 @@
08CBEA3A2D3FABE100248007 /* ToastView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08CBEA392D3FABE100248007 /* ToastView.swift */; };
08CBEA3C2D3FABED00248007 /* BookMarkToastView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08CBEA3B2D3FABED00248007 /* BookMarkToastView.swift */; };
08CBEA3E2D3FF6A100248007 /* PopUpCardView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08CBEA3D2D3FF6A100248007 /* PopUpCardView.swift */; };
08CFD3922D9BDE99004CDD50 /* DiskStorage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08CFD3912D9BDE99004CDD50 /* DiskStorage.swift */; };
08DC61F32CF75037002A2F44 /* KeyChainService.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08DC61F22CF75037002A2F44 /* KeyChainService.swift */; };
08DC61F52CF765B5002A2F44 /* UserDefaultService.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08DC61F42CF765B5002A2F44 /* UserDefaultService.swift */; };
08DC61F82CF76843002A2F44 /* SignUpCompleteView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 08DC61F72CF76843002A2F44 /* SignUpCompleteView.swift */; };
Expand Down Expand Up @@ -461,7 +464,6 @@
BDCA41CA2CF35AC1005EECF6 /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = BDCA41C92CF35AC1005EECF6 /* Assets.xcassets */; };
BDCA41CD2CF35AC1005EECF6 /* Base in Resources */ = {isa = PBXBuildFile; fileRef = BDCA41CC2CF35AC1005EECF6 /* Base */; };
BDCA41F22CF35D0D005EECF6 /* SnapKit in Frameworks */ = {isa = PBXBuildFile; productRef = BDCA41F12CF35D0D005EECF6 /* SnapKit */; };
BDCA41F52CF35D33005EECF6 /* Kingfisher in Frameworks */ = {isa = PBXBuildFile; productRef = BDCA41F42CF35D33005EECF6 /* Kingfisher */; };
BDCA41F82CF35D9A005EECF6 /* RxSwift in Frameworks */ = {isa = PBXBuildFile; productRef = BDCA41F72CF35D9A005EECF6 /* RxSwift */; };
BDCA41FE2CF35EE7005EECF6 /* ReactorKit in Frameworks */ = {isa = PBXBuildFile; productRef = BDCA41FD2CF35EE7005EECF6 /* ReactorKit */; };
BDCA42012CF35EFE005EECF6 /* RxKeyboard in Frameworks */ = {isa = PBXBuildFile; productRef = BDCA42002CF35EFE005EECF6 /* RxKeyboard */; };
Expand Down Expand Up @@ -728,6 +730,8 @@
0899526D2D0474340022AEF9 /* GetSearchPopUpListResponse.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = GetSearchPopUpListResponse.swift; sourceTree = "<group>"; };
089952722D0475E90022AEF9 /* SearchResultCountSection.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SearchResultCountSection.swift; sourceTree = "<group>"; };
089952742D0475F20022AEF9 /* SearchResultCountSectionCell.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SearchResultCountSectionCell.swift; sourceTree = "<group>"; };
089B4FD72D9A57AE00FC0CC3 /* ImageLoader.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ImageLoader.swift; sourceTree = "<group>"; };
089B4FDE2D9A8F9A00FC0CC3 /* MemoryStorage.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MemoryStorage.swift; sourceTree = "<group>"; };
08A2E46B2D15BC5000102313 /* CommentLikeRequestDTO.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CommentLikeRequestDTO.swift; sourceTree = "<group>"; };
08A2E4782D1B06A300102313 /* ImageDetailView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ImageDetailView.swift; sourceTree = "<group>"; };
08A2E47A2D1B06AA00102313 /* ImageDetailController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ImageDetailController.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -809,6 +813,7 @@
08CBEA392D3FABE100248007 /* ToastView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ToastView.swift; sourceTree = "<group>"; };
08CBEA3B2D3FABED00248007 /* BookMarkToastView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BookMarkToastView.swift; sourceTree = "<group>"; };
08CBEA3D2D3FF6A100248007 /* PopUpCardView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PopUpCardView.swift; sourceTree = "<group>"; };
08CFD3912D9BDE99004CDD50 /* DiskStorage.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DiskStorage.swift; sourceTree = "<group>"; };
08DC61F22CF75037002A2F44 /* KeyChainService.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = KeyChainService.swift; sourceTree = "<group>"; };
08DC61F42CF765B5002A2F44 /* UserDefaultService.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = UserDefaultService.swift; sourceTree = "<group>"; };
08DC61F72CF76843002A2F44 /* SignUpCompleteView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SignUpCompleteView.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -931,7 +936,6 @@
files = (
BDCA41F82CF35D9A005EECF6 /* RxSwift in Frameworks */,
BDCA420D2CF35FD2005EECF6 /* RxGesture in Frameworks */,
BDCA41F52CF35D33005EECF6 /* Kingfisher in Frameworks */,
BDCA42072CF35FA6005EECF6 /* Tabman in Frameworks */,
BDCA42042CF35F76005EECF6 /* PanModal in Frameworks */,
082197A12D426DCB0054094A /* Then in Frameworks */,
Expand Down Expand Up @@ -1427,6 +1431,7 @@
083A25A02CF3623C0099B58E /* Infrastructure */ = {
isa = PBXGroup;
children = (
089B4FD62D9A576F00FC0CC3 /* ImageLoader */,
0841BA832CF9F61500049E31 /* PreSignedService */,
083A25B12CF362670099B58E /* NetworkLayer */,
08DC61F42CF765B5002A2F44 /* UserDefaultService.swift */,
Expand Down Expand Up @@ -2244,6 +2249,16 @@
path = View;
sourceTree = "<group>";
};
089B4FD62D9A576F00FC0CC3 /* ImageLoader */ = {
isa = PBXGroup;
children = (
089B4FD72D9A57AE00FC0CC3 /* ImageLoader.swift */,
089B4FDE2D9A8F9A00FC0CC3 /* MemoryStorage.swift */,
08CFD3912D9BDE99004CDD50 /* DiskStorage.swift */,
);
path = ImageLoader;
sourceTree = "<group>";
};
08A2E4772D1B069300102313 /* ImageDetail */ = {
isa = PBXGroup;
children = (
Expand Down Expand Up @@ -2988,7 +3003,6 @@
name = Poppool;
packageProductDependencies = (
BDCA41F12CF35D0D005EECF6 /* SnapKit */,
BDCA41F42CF35D33005EECF6 /* Kingfisher */,
BDCA41F72CF35D9A005EECF6 /* RxSwift */,
BDCA41FD2CF35EE7005EECF6 /* ReactorKit */,
BDCA42002CF35EFE005EECF6 /* RxKeyboard */,
Expand Down Expand Up @@ -3037,7 +3051,6 @@
mainGroup = BDCA41B42CF35AC0005EECF6;
packageReferences = (
BDCA41F02CF35D0D005EECF6 /* XCRemoteSwiftPackageReference "SnapKit" */,
BDCA41F32CF35D33005EECF6 /* XCRemoteSwiftPackageReference "Kingfisher" */,
BDCA41F62CF35D9A005EECF6 /* XCRemoteSwiftPackageReference "RxSwift" */,
BDCA41FC2CF35EE7005EECF6 /* XCRemoteSwiftPackageReference "ReactorKit" */,
BDCA41FF2CF35EFE005EECF6 /* XCRemoteSwiftPackageReference "RxKeyboard" */,
Expand Down Expand Up @@ -3190,11 +3203,13 @@
4E685EDB2D12CEB6001EF91C /* MapAPIEndpoint.swift in Sources */,
086F89CC2D1E42B000CA4FC9 /* CommentUserBlockController.swift in Sources */,
08DC62032CF8AC06002A2F44 /* HomeView.swift in Sources */,
089B4FD82D9A57AE00FC0CC3 /* ImageLoader.swift in Sources */,
BD9103622CF6149D00BBCCAE /* LoginResponseDTO.swift in Sources */,
083C86642D0EC4A5003F441C /* InstaCommentAddReactor.swift in Sources */,
08DE8A3F2D54DCC40049BCAC /* MyCommentedPopUpGridSection.swift in Sources */,
081898C52D30AEF40067BF01 /* GetMyProfileResponse.swift in Sources */,
BD9103922CF6166800BBCCAE /* SplashView.swift in Sources */,
089B4FDF2D9A8F9A00FC0CC3 /* MemoryStorage.swift in Sources */,
0899526E2D0474340022AEF9 /* GetSearchPopUpListResponse.swift in Sources */,
08B191392CF366680057BC04 /* UITableViewCell+.swift in Sources */,
08A2E48F2D1BF6E500102313 /* CommentListView.swift in Sources */,
Expand Down Expand Up @@ -3344,6 +3359,8 @@
BD9103652CF6149D00BBCCAE /* HomeAPIEndpoint.swift in Sources */,
086DD8E32CFF356300B97D3B /* HomeCardGridSection.swift in Sources */,
0841BABE2CFB5AA600049E31 /* Date?+.swift in Sources */,
083A258D2CF361F90099B58E /* ConventionCollectionViewCell.swift in Sources */,
08CFD3922D9BDE99004CDD50 /* DiskStorage.swift in Sources */,
4E685EE12D12CEB6001EF91C /* StoreListReactor.swift in Sources */,
4E685EE52D12CEB6001EF91C /* MapMarker.swift in Sources */,
081898FB2D33D9320067BF01 /* GetBlockUserListResponseDTO.swift in Sources */,
Expand Down Expand Up @@ -3866,14 +3883,6 @@
minimumVersion = 5.7.1;
};
};
BDCA41F32CF35D33005EECF6 /* XCRemoteSwiftPackageReference "Kingfisher" */ = {
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/onevcat/Kingfisher.git";
requirement = {
kind = upToNextMajorVersion;
minimumVersion = 8.1.1;
};
};
BDCA41F62CF35D9A005EECF6 /* XCRemoteSwiftPackageReference "RxSwift" */ = {
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/ReactiveX/RxSwift.git";
Expand Down Expand Up @@ -3993,11 +4002,6 @@
package = BDCA41F02CF35D0D005EECF6 /* XCRemoteSwiftPackageReference "SnapKit" */;
productName = SnapKit;
};
BDCA41F42CF35D33005EECF6 /* Kingfisher */ = {
isa = XCSwiftPackageProductDependency;
package = BDCA41F32CF35D33005EECF6 /* XCRemoteSwiftPackageReference "Kingfisher" */;
productName = Kingfisher;
};
BDCA41F72CF35D9A005EECF6 /* RxSwift */ = {
isa = XCSwiftPackageProductDependency;
package = BDCA41F62CF35D9A005EECF6 /* XCRemoteSwiftPackageReference "RxSwift" */;
Expand Down
177 changes: 0 additions & 177 deletions Poppool/Poppool.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop

This file was deleted.

Loading