Skip to content

Conversation

@ferblape
Copy link
Member

🎩 What? Why?

Please describe your pull request.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@codecov-commenter
Copy link

Codecov Report

Merging #2 (11d0dee) into develop (df7189d) will decrease coverage by 50.42%.
The diff coverage is 20.95%.

@@             Coverage Diff              @@
##           develop       #2       +/-   ##
============================================
- Coverage    90.01%   39.58%   -50.43%     
============================================
  Files         2978     2978               
  Lines        62044    77975    +15931     
============================================
- Hits         55850    30868    -24982     
- Misses        6194    47107    +40913     
Flag Coverage Δ
decidim-accountability ?
decidim-admin 20.48% <19.41%> (-47.85%) ⬇️
decidim-api 14.92% <19.41%> (-37.37%) ⬇️
decidim-assemblies ?
decidim-blogs 20.33% <19.41%> (-39.04%) ⬇️
decidim-budgets ?
decidim-comments 22.45% <19.41%> (-40.11%) ⬇️
decidim-conferences ?
decidim-consultations 24.23% <19.41%> (-39.64%) ⬇️
decidim-core 20.46% <20.95%> (-54.27%) ⬇️
decidim-debates ?
decidim-dev 10.83% <19.41%> (-35.34%) ⬇️
decidim-elections ?
decidim-elections-system-admin ?
decidim-elections-system-public ?
decidim-forms 16.53% <19.41%> (-37.02%) ⬇️
decidim-generators ?
decidim-initiatives 25.74% <19.41%> (-43.34%) ⬇️
decidim-meetings ?
decidim-meetings-system-admin ?
decidim-meetings-system-public ?
decidim-pages 18.71% <19.41%> (-38.64%) ⬇️
decidim-participatory_processes ?
decidim-proposals 26.55% <19.41%> (-40.68%) ⬇️
decidim-proposals-system-admin ?
decidim-proposals-system-public ?
decidim-sortitions 20.61% <19.41%> (-38.82%) ⬇️
decidim-surveys ?
decidim-system 15.85% <19.41%> (-37.86%) ⬇️
decidim-templates 16.60% <19.41%> (-37.18%) ⬇️
decidim-verifications 22.26% <19.41%> (-39.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...controllers/decidim/activity_browser_controller.rb 0.00% <0.00%> (ø)
decidim-core/lib/tasks/decidim_activities.rake 27.58% <27.58%> (ø)
decidim-core/app/models/decidim/activity.rb 100.00% <100.00%> (ø)
decidim-forms/lib/decidim/forms/test.rb 0.00% <0.00%> (-100.00%) ⬇️
decidim-core/app/jobs/decidim/metric_job.rb 0.00% <0.00%> (-100.00%) ⬇️
decidim-core/app/cells/decidim/badges_cell.rb 0.00% <0.00%> (-100.00%) ⬇️
decidim-core/app/cells/decidim/groups_cell.rb 0.00% <0.00%> (-100.00%) ⬇️
decidim-core/app/cells/decidim/members_cell.rb 0.00% <0.00%> (-100.00%) ⬇️
decidim-core/app/jobs/decidim/open_data_job.rb 0.00% <0.00%> (-100.00%) ⬇️
decidim-core/app/cells/decidim/tos_page_cell.rb 0.00% <0.00%> (-100.00%) ⬇️
... and 1581 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df7189d...11d0dee. Read the comment docs.

entantoencuanto pushed a commit that referenced this pull request Nov 6, 2025
* Bump Rails to v7.2

* Set branch

* Set rails 7.1 defaults

* Successfully generate test_app

* Fix (Taxonomies): PG::UndefinedFunction: ERROR:  operator does not exist: integer[] @> text[]

* Fix activeStorage url

* Fix: PG::SyntaxError: ERROR:  syntax error at or near "{"
            LINE 1: ..."decidim_users"."type" = $1 AND (extended_data @> {"ephemera...

* Fix: PG::SyntaxError: ERROR:  syntax error at or near "{" LINE 1: ...dim_action_logs"."resource_id" = $2 AND (extra @> {"edit":tr...

* Fix: private method `warn' called for class ActiveSupport::Deprecation

* Fix: PG::SyntaxError: ERROR:  syntax error at or near "$3" LINE 1: ...ings->'global'->>'geocoding_enabled')::boolean is $3 or mani...

* Fix: Unable to find link or button with id dc-dialog-accept

* Fix encoding issues on TimeWithZone

* Fix: PG::NotNullViolation: ERROR:  null value in column "record_id" of relation "active_storage_attachments" violates not-null constraint

* ArgumentError: Decidim::Proposals::Proposal model aliases `state`, but `state` is not an attribute. Use `alias_method :internal_state, :state` or define the method manually. (ArgumentError)

* Disable job processing

* Fix flaky specs caused by jobs not being finished when assertion is performed

* Running rubocops

* Update decidim-generators/lib/decidim/generators/app_generator.rb

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Attempt to fix the Comments specs

* Attempt to fix the Comments specs #2

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Update active_job.rb

---------

Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants