Implement routing to delete operation for resources with _exist set to false #1317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
requested changes
Dec 15, 2025
| $out.changedProperties | Should -BeNullOrEmpty | ||
| } | ||
|
|
||
| It '_exist false routes to delete operation' { |
Member
There was a problem hiding this comment.
Is there a test case to handle what-if for this scenario?
Contributor
Author
There was a problem hiding this comment.
Is --what-if not only for dsc config? I can't seem to find them on dsc resource options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes
dsc resource setto route to the delete operation when_existis set tofalsefor resources that have theDeletecapability but notSetHandlesExist.The implementation mirrors the existing logic from configuration documents and reuses the
get_difffunction for calculating thechangedProperties. I've decided to manually construct theSetResultresponse sincedelete()returns()rather than state info as a design decision.PR Context
Fixes #1268.