Add sshd pester tests #789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
Adds end-to-end Pester tests for the SSH server (sshd) and a cleanup test for the SSH client, and exposes the sshd service name in the test helper.
- Introduces
SSHD.Tests.ps1with two SSHD-focused tests (LoginGraceTime expiry and virtual account spawning) - Extends
SSH.Tests.ps1to verify that closing an SSH session cleans up child processes - Updates
OpenSSHTestHelper.psm1to includeSshdServiceNamein the test environment
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| regress/pesterTests/SSHD.Tests.ps1 | New end-to-end tests for sshd child processes and accounts |
| regress/pesterTests/SSH.Tests.ps1 | Added test verifying SSH session exit cleans up sshd PIDs |
| contrib/win32/openssh/OpenSSHTestHelper.psm1 | Added SshdServiceName entry to $OpenSSHTestInfo |
Co-authored-by: Copilot <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vthiebaut10
approved these changes
Jul 21, 2025
| $sshdPidsCountAfter = (Get-Process -Name sshd* | Select-Object -ExpandProperty Id).Count | ||
|
|
||
| if ($sshProc -and !$sshProc.HasExited) { | ||
| $sshProc | Stop-Process -Force |
There was a problem hiding this comment.
If ssh process hasn't exited, should you also fail the test? Because that means that the time out failed, right?
There was a problem hiding this comment.
This cleans up the ssh client process which will still be waiting on user input, even if the server side time out is successful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context