Skip to content

Add Missing LoRA Parameters #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Missing LoRA Parameters #550

wants to merge 1 commit into from

Conversation

@kyleavery
Copy link
Contributor

@kyleavery kyleavery commented Nov 9, 2025

Description

The code previously did not pass use_rslora, lora_dropout, or modules_to_save to LoraConfig.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test improvement

Testing

  • All existing tests pass when running uv run pytest locally.
  • New tests have been added to cover the changes

Checklist

  • My code follows the style guidelines of this project as outlined in AGENTS.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Additional Notes

@kyleavery kyleavery mentioned this pull request Nov 9, 2025
Open
ronaldnetawat pushed a commit to ronaldnetawat/verifiers that referenced this pull request Nov 13, 2025
@willccbb @mikasenghaas @samsja
Add verifiers environments (PrimeIntellect-ai#540)
a9f5749 
* verifiers integration v0.0

* verifiers integration v0.0

* training finishes on reversetext

* reverse_text trains 0.13 -> 0.70

* pin git branch in pyproject

* removed ac in config

* remove DataConfig

* removed print debug

* configurable masks

* rm dataconfig instance

* pinned vf commit, removed extra deps

* registry cleanup, reworked gsm8k, removed default env

* bumped verifiers commit, fixed training divergence vs refactor branch

* vf simple-math

* simple-math edits

* debug

* simple_math train matching reference

* rename math tasks, port to verifiers

* Update configs

* Fix imports

* Add back envs that were accidentically deleted during rebase

* Fix sampling.n missing and unused vars

* Remove redundant log

* Update README with new task names

* Fix hendrycks math config path in README

* Update W&B project names

* Fix wrong config key

* Add missing import

* Fix sampling.n not defined

* Fix missing config key

* Do not tokenize in eval

* Fix typos

* Add 1B and 7B hendryck's and intellect math

* Remove comment

* fix tests and configs (PrimeIntellect-ai#548)

* add tests orch

* fix configs

* fix configs

* fix tests

* fix pydantic ofnig

* fix tetstp

* Dispatch subconfigs via tmp toml file

* Add correct GPU placement for int math run

* More consistent var names

* Set project and model also in orchestrator

* Update readme (PrimeIntellect-ai#550)

* fix readme

* fix scripts

* Parse single-turn prompt and completions tokens/ logprobs from vLLM directly via mock process_env_results function

* Update verifiers rev

* Fix style

* Do not filter if field is missing

---------

Co-authored-by: Mika Senghaas <[email protected]>
Co-authored-by: samsja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kyleavery