Skip to content

XPROJ-67: Adding installer option to skip docker executor building #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
epdl wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

XPROJ-67: Adding installer option to skip docker executor building #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "processmaker/docker-executor-php",
"friendly_name": "PHP Docker Executor",
"description": "PHP script executor for processmaker 4",
"version": "1.4.0",
"version": "1.4.1",
"minimum-stability": "dev",
"license": "GAGPL-3.0-or-later",
"autoload": {
Expand Down
11 changes: 5 additions & 6 deletions src/DockerExecutorPhpServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ class DockerExecutorPhpServiceProvider extends ServiceProvider
{
use PluginServiceProviderTrait;

const version = '1.0.0'; // Required for PluginServiceProviderTrait
public const version = '1.4.1'; // Required for PluginServiceProviderTrait

public function register()
{
}

public function boot()
{
\Artisan::command('docker-executor-php:install', function () {
\Artisan::command('docker-executor-php:install {--no-build : Skip building the script executor image}', function () {
$scriptExecutor = ScriptExecutor::install([
'language' => 'php',
'title' => 'PHP Executor',
Expand All @@ -28,10 +28,9 @@ public function boot()
]);

// Build the instance image. This is the same as if you were to build it from the admin UI
\Artisan::call('processmaker:build-script-executor ' . $scriptExecutor->id);

// Restart the workers so they know about the new supported language
// \Artisan::call('horizon:terminate');
if (!$this->option('no-build')) {
\Artisan::call('processmaker:build-script-executor ' . $scriptExecutor->id);
}
});

$this->commands([TestDocs::class]);
Expand Down