Skip to content

Conversation

afarber
Copy link
Contributor

@afarber afarber commented Sep 5, 2025

Issue

Fix the issues #7228 and #7229 by:

  • Update npm packages
  • Define modern lint rules and fix existing problems in JS files
  • Add husky pre-commit hooks for compiling and linting staged JS files
  • Simplify eslint and cucumber-js calls by using npx

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@afarber afarber changed the title 7228 7229 pre commit hook Inprove lint rules, update npm packages, add pre-commit hook Sep 5, 2025
@afarber afarber changed the title Inprove lint rules, update npm packages, add pre-commit hook Improve lint rules, update npm packages, add pre-commit hook Sep 5, 2025
@afarber
Copy link
Contributor Author

afarber commented Sep 6, 2025

Hi @DennisOSRM please review my PR.

I have also tried to update the api.md Wiki but I cannot submit the changed file because that repo is archived.

Here is the updated file as attachment: api.md

Here is the updated file in my forked repo: https://github.com/afarber/node-osrm/blob/patch-1/docs/api.md

Maybe you have an idea how to update the Wiki properly with the file.

Finally, please consider discarding your own PR #7177 because it is covered by this PR.

Copy link
Collaborator

@DennisOSRM DennisOSRM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Love the husky pre commit hook to enforce style. Thx!

@DennisOSRM DennisOSRM merged commit e9a97de into Project-OSRM:master Sep 6, 2025
21 checks passed
@afarber afarber deleted the 7228-7229-pre-commit-hook branch September 24, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants