-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Add std::format compatibility layer and fix node_osrm C++17/C++20 ABI mismatch #7261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Hi @DennisOSRM and @SiarheiFedartsou please review my PR. It would allow moving users on newer systems to Also it fixes an ABI mismatch, which was causing not found |
DennisOSRM
approved these changes
Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7260 by addressing two issues:
1. std::format compatibility layer
Adds runtime detection and fallback for C++20
std::format:std::formatwhen available and fully functionalfmt::formatfor incomplete implementations (e.g., Clang with older libstdc++ missing symbols)<cmath>before<format>to preventstd::isfiniteconflicts2. Fix node_osrm C++ standard mismatch
When #6877 moved the project to C++20 in May 2024, src/nodejs/CMakeLists.txt was overlooked.
This caused node_osrm to be compiled with C++17 while linking against libosrm compiled with C++20,
creating an ABI mismatch. This PR updates node_osrm to C++20 to match the rest of the codebase.
Tasklist
Requirements / Relations
#7251