refactor: problem bound structure #143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tubadzin
commented
May 27, 2025
tubadzin
commented
May 27, 2025
| } | ||
|
|
||
| public void compareBound() { | ||
| if (this.solution == null) { |
Contributor
Author
There was a problem hiding this comment.
Can we outsource this check to BoundWithInfo or ComparisonDto? It would be nice if we would have an indicator by a method call from the class which signalizes that the bound may not be set - isBoundSet() for instance?
| import edu.kit.provideq.toolbox.BoundWithInfo; | ||
| import edu.kit.provideq.toolbox.Solution; | ||
|
|
||
| public record ComparisonDto(float comparison, BoundWithInfo bound, Solution<?> solution) { |
Contributor
Author
There was a problem hiding this comment.
It would be nice if you included an JavaDoc for this class
Introduced a hasBound() method in ComparisonDto to check for the presence of a bound. Updated Problem to use hasBound() instead of directly checking for null
…/ProvideQ/toolbox-server into refactor/problem-bound-structure
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.