strconv: replace Ryu ftoa with Dragonbox #56
+1,522
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinderek
force-pushed
the
master
branch
2 times, most recently
from
d50240b to
8bcda6c
Compare
austinderek
force-pushed
the
master
branch
22 times, most recently
from
d50240b to
8bcda6c
Compare
austinderek
force-pushed
the
master
branch
4 times, most recently
from
6a08e80 to
70b640f
Compare
austinderek
force-pushed
the
master
branch
30 times, most recently
from
2a71af1 to
5bf50a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dragonbox is a faster ftoa algorithm that provides the same guarantees
as Ryu: round-trip conversion, shortest length, and correct rounding.
The author of the reference implementation has agreed to distribute
this file under Go's BSD-style license.
The new implementation has been fuzz-tested against the current
Ryu implementation in addition to the existing test suite.
Benchmarks show at least ~15-20% performance improvement.
Benchmarks and fuzz-testing code are available at:
https://github.com/taichimaeda/dragonbox-bench/
Dragonbox only supports shortest-precision conversion, so we continue to
use Ryu-printf for fixed precision.
Fixes golang#74886
🔄 This is a mirror of upstream PR golang#75195