debug/elf: check if symbol section of 64-bit binary is empty to prevent panic #70
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinderek
force-pushed
the
master
branch
17 times, most recently
from
e6605a1 to
37c78b5
Compare
…and 32-bit binaries The check for whether a binary's symbols section is empty is inconsistent across the 32-bit and 64-bit flows.
austinderek
force-pushed
the
patch-debug-elf-panic
branch
from
c9e41f5 to
f264915
Compare
austinderek
force-pushed
the
master
branch
10 times, most recently
from
37c78b5 to
c5737dc
Compare
austinderek
force-pushed
the
master
branch
30 times, most recently
from
5500cbf to
d17a28a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally raised in golang#62649. The fix (checking for empty symbols section)
was only applied to the 32-bit executables flow. This commit adds the same
fix for the 64-bit executables flow.
Original fix: https://go-review.googlesource.com/c/go/+/528655
Updates golang#62649
🔄 This is a mirror of upstream PR golang#75334