Fix unicode errors when rendering to IPython notebook #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do no make Pygments encode highlighted source code, keep unicode. This is already done for NodeList and ProxyList, fix Node and EndlNode.
NodeList and ProxyList do a unicode join() to construct the final unicode object; ths makes every element unicode to begin with, to avoid automatic decoding.
|
Hello, Do you think that it's possible to write a test for that? Nevertheless, thanks a lot for this pull request :) Kinds regards, |
|
I'm sure I can make you something... There's a risk I might find other unicode-related issues though 😉 |
|
That would be great! |
|
As I thought, RedBaron() expects bytes on Python 2 and str on Python 3 😢 I added a test, but it doesn't pass on Python 3: it looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kinda-fixes PyCQA/baron#66: the example notebook linked there now works (if input is bytes).