Skip to content

Canonicalize Adjoint of Rotation. #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Canonicalize Adjoint of Rotation. #482

wants to merge 6 commits into from

Conversation

weinbe58
Copy link
Member

@weinbe58 weinbe58 commented Sep 2, 2025 •
edited
Loading

applies: Adj(Rot(angle, axis)) -> Rot(-angle, Adj(axis))

@codecov Codecov
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@cduck
Copy link
Contributor

cduck commented Sep 2, 2025 •
edited
Loading

I disagree with the statement Adj(Rot(angle, axis)) -> Rot(-angle, Adj(axis)). The negative angle and the opposite-direction axis both invert and therefore cancel each other out.

Should be
Adj(Rot(angle, axis)) -> Rot(angle, Adj(axis))
OR
Adj(Rot(angle, axis)) -> Rot(-angle, axis)

EDIT: Talked offline.

cduck
cduck requested changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@cduck cduck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do the adjoint twice.

Also, I suggest you check that this doesn't change the meaning of controlled-rotation gates when the rotation is an adjoint.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11008 9652 88% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/bloqade/squin/op/rewrite.py 97% 🟢
TOTAL 97% 🟢

updated for commit: 0aadd4d by action🐍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cduck cduck cduck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weinbe58 @cduck