Skip to content

Conversation

weinbe58
Copy link
Member

Closes #508 however I am not sure where to reexport new since I Can't reexport it into the qubit module. For now I have re-exported it into squin.new.

@weinbe58 weinbe58 linked an issue Sep 30, 2025 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/bloqade/analysis/address/impls.py 66.66% 3 Missing ⚠️
src/bloqade/squin/stdlib/qubit.py 62.50% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

github-actions bot commented Sep 30, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11102 9738 88% 0% 🟢

New Files

File Coverage Status
src/bloqade/squin/stdlib/qubit.py 63% 🟢
TOTAL 63% 🟢

Modified Files

File Coverage Status
src/bloqade/analysis/address/impls.py 88% 🟢
src/bloqade/pyqrack/squin/qubit.py 98% 🟢
src/bloqade/squin/_init_.py 100% 🟢
src/bloqade/squin/analysis/address_impl.py 97% 🟢
src/bloqade/squin/qubit.py 100% 🟢
TOTAL 96% 🟢

updated for commit: 8396e77 by action🐍

@weinbe58 weinbe58 marked this pull request as draft September 30, 2025 20:11
@david-pl
Copy link
Collaborator

david-pl commented Oct 1, 2025

@weinbe58 I thought this was meant to replace the qubit.New statement altogether. If so, then just replace the wrapper by the stdlib function in qubit.new.

@weinbe58 weinbe58 marked this pull request as ready for review October 1, 2025 15:34
@weinbe58
Copy link
Member Author

weinbe58 commented Oct 1, 2025

@weinbe58 I thought this was meant to replace the qubit.New statement altogether. If so, then just replace the wrapper by the stdlib function in qubit.new.

either way I need to put the new stdlib function outside of the qubit.py module because otherwise it will create a circular import

@weinbe58
Copy link
Member Author

weinbe58 commented Oct 6, 2025

TODO:

  • rename new to qalloc
  • Remove analysis for ilist.map for now, create another PR later.



@wraps(NewQubit)
def new_qubit() -> Qubit:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename NewQubit -> New

@weinbe58 weinbe58 added the breaking breaking changes or proposed changes that would break existing APIs label Oct 6, 2025
@weinbe58 weinbe58 added the do not merge do not merge pending on other issues to resolve label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking breaking changes or proposed changes that would break existing APIs do not merge do not merge pending on other issues to resolve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simplifying qubit.new
3 participants