Skip to content

Conversation

HumphreyYang
Copy link
Member

Key changes:

  • Removed PyMC: Removed all PyMC imports, installations, and model implementations
  • Updated variable naming: Used Greek letters (ρ, σ) instead of rho, sigma in NumPyro code
  • Code cleanup:
    • Cleaned up NumPyro implementation while preserving discussions
    • Fixed minor typos ("kernal" → "kernel")

@HumphreyYang HumphreyYang changed the title Removed PyMC dependency and style-sheet compliance [ar1_bayes] Removed PyMC dependency and style-sheet compliance Aug 22, 2025
Copy link

github-actions bot commented Aug 22, 2025

@github-actions github-actions bot temporarily deployed to pull request August 22, 2025 04:03 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 22, 2025 04:03 Inactive
@mmcky mmcky added the lecture label Aug 29, 2025
@HumphreyYang HumphreyYang marked this pull request as ready for review August 31, 2025 06:46
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HumphreyYang -- just one minor comment re: citation. Should I organise @thomassargent30 to review?

@mmcky mmcky requested a review from Copilot August 31, 2025 22:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes PyMC as a dependency from the AR(1) Bayesian analysis lecture, simplifying the codebase to use only NumPyro for Bayesian inference. The changes modernize variable naming conventions and clean up the implementation.

Key changes:

  • Removed all PyMC imports, installations, and model implementations
  • Updated variable naming to use Greek letters (ρ, σ) instead of Latin equivalents
  • Fixed minor typos and improved code consistency

@mmcky mmcky added the review label Aug 31, 2025
@github-actions github-actions bot temporarily deployed to pull request September 1, 2025 22:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 1, 2025 22:09 Inactive
@HumphreyYang
Copy link
Member Author

Thanks @HumphreyYang -- just one minor comment re: citation. Should I organise @thomassargent30 to review?

Thanks Matt, I think it's fine. This is a minor change : )

@mmcky
Copy link
Contributor

mmcky commented Sep 3, 2025

thanks @HumphreyYang are you happy for me to merge this?

@mmcky mmcky requested a review from jstac September 5, 2025 01:29
@github-actions github-actions bot temporarily deployed to pull request September 5, 2025 18:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 5, 2025 18:12 Inactive
@jstac
Copy link
Contributor

jstac commented Sep 7, 2025

@mmcky Where do I find the latest deployment?

I can see above "🚀 Deployed on https://68bb28185ee35015bb2cce79--nostalgic-wright-5fa355.netlify.app/"

I'm guessing this is out of date because it's not compliant with the syle manual (e.g., sentences running together instead of being followed by line breaks).

I find this PR a bit hard to jump into quickly because I'm unsure of the deployment and the title of the lecture is missing.

@github-actions github-actions bot temporarily deployed to pull request September 7, 2025 07:52 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 7, 2025 07:52 Inactive
@HumphreyYang
Copy link
Member Author

HumphreyYang commented Sep 7, 2025

@mmcky Where do I find the latest deployment?

Many thanks @jstac, please see the latest deployment of the lecture Posterior Distributions for AR(1) Parameters:
https://68bd39bc9ca87aaef6818d45--nostalgic-wright-5fa355.netlify.app/ar1_bayes

We will include the lecture title and the latest deployment of the lecture next time we ping you for review.

Many thanks in advance!

(I pushed some more updates since I found some more paragraphs with multiple sentences)

@mmcky
Copy link
Contributor

mmcky commented Sep 7, 2025

@HumphreyYang doing some testing of the style-guide compliance using copilot. We can incorporate the useful components from #593 once it is completed.

@mmcky
Copy link
Contributor

mmcky commented Sep 8, 2025

@copilot I have attached our style-guide quantecon_review_instructions.md.

quantecon_review_instructions.md

Can you please review this lecture ar1_bayes and make sure it is style guide compliant.

Are you able to do a full review of this lecture and not just a review of the changes.

@mmcky
Copy link
Contributor

mmcky commented Sep 8, 2025

@copilot I have attached our style-guide quantecon_review_instructions.md.

quantecon_review_instructions.md

Can you please review this lecture ar1_bayes and make sure it is style guide compliant.

Are you able to do a full review of this lecture and not just a review of the changes.

@HumphreyYang this sort of triggering doesn't work. I think it will only work when a PR is authored initially by copilot. I will do a full pass of this lecture on my local machine re: style compliance.

@HumphreyYang
Copy link
Member Author

Many thanks @mmcky, this PR should be compliant since I have run the same instruction on my end, but please let me know if your run spots anything new!

@mmcky
Copy link
Contributor

mmcky commented Sep 8, 2025

thanks @HumphreyYang -- you're right. I'll open an issue to figure out how we can improve the netlify deployment links. I find it interesting it doesn't post the latest one after each build.

@github-actions github-actions bot temporarily deployed to pull request September 8, 2025 01:29 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 8, 2025 01:29 Inactive
@HumphreyYang
Copy link
Member Author

thanks @HumphreyYang -- you're right. I'll open an issue to figure out how we can improve the netlify deployment links. I find it interesting it doesn't post the latest one after each build.

Many thanks @mmcky! It's interesting that it posts deployment this time : )

@mmcky
Copy link
Contributor

mmcky commented Sep 9, 2025

@HumphreyYang it looks like netlify deployments disappear! Maybe that is part of the issue we are having.

This comment was marked as outdated.

This comment was marked as outdated.

@github-actions github-actions bot temporarily deployed to pull request September 9, 2025 03:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 10, 2025 01:48 Inactive
Copy link

📖 Netlify Preview Ready!

Preview URL: https://pr-569--sunny-cactus-210e3e.netlify.app (7e829d7)

📚 Changed Lecture Pages: ar1_bayes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants