Skip to content

Conversation

HumphreyYang
Copy link
Member

This PR incorprates changes from Yiqing's notebook and some typo fixes with suggestions from reader's perspective.

Copy link

github-actions bot commented Sep 1, 2025

@github-actions github-actions bot temporarily deployed to pull request September 1, 2025 15:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 1, 2025 15:10 Inactive
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HumphreyYang -- would you mind moving quantecon_review_insructions.md to .github folder (That is where I usually store copilot or ai assets). If you think there is a better location let me know -- but if it is in the lectures folder then we need to add it to jb to ignore etc.

It looks like a nice set of instructions btw. I might use it as another test source for our quantecon-style-checker.

@HumphreyYang
Copy link
Member Author

Thanks @mmcky. I have removed it for now. Let’s add it in another PR!

@github-actions github-actions bot temporarily deployed to pull request September 2, 2025 07:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 2, 2025 07:23 Inactive

This comment was marked as outdated.

This comment was marked as outdated.

@github-actions github-actions bot temporarily deployed to pull request September 9, 2025 04:20 Inactive
Copy link

@HumphreyYang
Copy link
Member Author

Hi @mmcky, this PR contains some fixes that we want to publish. Could you please have a look at the preview of the lectures when you have time, and I will merge and publish this?

We can then iterate it as a part of the improvement project!

@HumphreyYang HumphreyYang marked this pull request as ready for review September 11, 2025 09:57
@mmcky
Copy link
Contributor

mmcky commented Sep 11, 2025

thanks @HumphreyYang -- please go ahead when you're ready.

@HumphreyYang
Copy link
Member Author

Many thanks @mmcky!

@HumphreyYang HumphreyYang merged commit 18666c0 into main Sep 12, 2025
1 check passed
@HumphreyYang HumphreyYang deleted the suggestions-info branch September 12, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants