Skip to content

Conversation

matheusvillasb
Copy link
Contributor

-Proofread, checked all links and references
-Updated maths to style guide
-Added a few comments to solve questions I had while reading the document

@mmcky
Copy link
Contributor

mmcky commented Sep 12, 2025

@matheusvillasb -- @HumphreyYang has answers to the questions you asked here #609 (comment) from #609.

Copy link

📖 Netlify Preview Ready!

Preview URL: https://pr-613--sunny-cactus-210e3e.netlify.app (53352eb)

📚 Changed Lecture Pages: lqcontrol

@mmcky mmcky removed the in-work label Sep 17, 2025
@matheusvillasb matheusvillasb marked this pull request as ready for review September 17, 2025 00:23
@mmcky
Copy link
Contributor

mmcky commented Sep 17, 2025

@matheusvillasb the syntax around links wasn't formatted correctly. Checkout https://manual.quantecon.org/styleguide/doclinks.html and a99a241

Copy link

📖 Netlify Preview Ready!

Preview URL: https://pr-613--sunny-cactus-210e3e.netlify.app (a99a241)

📚 Changed Lecture Pages: lqcontrol

Copy link

📖 Netlify Preview Ready!

Preview URL: https://pr-613--sunny-cactus-210e3e.netlify.app (cf57cac)

📚 Changed Lecture Pages: lqcontrol

@mmcky
Copy link
Contributor

mmcky commented Sep 17, 2025

@matheusvillasb this lecture has quite a few style guide violations such as

Do you mind doing another pass? Note: there have been edits to this branch so you should git pull origin edit-lqcontrol before making any additional changes.

@HumphreyYang I see there is a model in this lecture. Do you think we should use NamedTuple (in similar style to the JAX conversions)?

@HumphreyYang
Copy link
Member

HumphreyYang commented Sep 17, 2025

@HumphreyYang I see there is a model in this lecture. Do you think we should use NamedTuple (in similar style to the JAX conversions)?

Many thanks @matheusvillasb and @mmcky,

Yes, I think it would be better by putting these argument into a class LQParams(NamedTuple) instead of globals:

r = 0.05
β = 1 / (1 + r)
T = 45
c_bar = 2
σ = 0.25
μ = 1
q = 1e6

@matheusvillasb
Copy link
Contributor Author

@matheusvillasb this lecture has quite a few style guide violations such as

Do you mind doing another pass? Note: there have been edits to this branch so you should git pull origin edit-lqcontrol before making any additional changes.

@HumphreyYang I see there is a model in this lecture. Do you think we should use NamedTuple (in similar style to the JAX conversions)?

@mmcky I'll do that! Thank you for picking these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants