-
-
Notifications
You must be signed in to change notification settings - Fork 53
[lqcontrol] style guide review and updated maths #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@matheusvillasb -- @HumphreyYang has answers to the questions you asked here #609 (comment) from #609. |
📖 Netlify Preview Ready! Preview URL: https://pr-613--sunny-cactus-210e3e.netlify.app (53352eb) 📚 Changed Lecture Pages: lqcontrol |
@matheusvillasb the syntax around links wasn't formatted correctly. Checkout https://manual.quantecon.org/styleguide/doclinks.html and a99a241 |
📖 Netlify Preview Ready! Preview URL: https://pr-613--sunny-cactus-210e3e.netlify.app (a99a241) 📚 Changed Lecture Pages: lqcontrol |
📖 Netlify Preview Ready! Preview URL: https://pr-613--sunny-cactus-210e3e.netlify.app (cf57cac) 📚 Changed Lecture Pages: lqcontrol |
@matheusvillasb this lecture has quite a few style guide violations such as
Do you mind doing another pass? Note: there have been edits to this branch so you should @HumphreyYang I see there is a model in this lecture. Do you think we should use NamedTuple (in similar style to the JAX conversions)? |
Many thanks @matheusvillasb and @mmcky, Yes, I think it would be better by putting these argument into a r = 0.05
β = 1 / (1 + r)
T = 45
c_bar = 2
σ = 0.25
μ = 1
q = 1e6 |
@mmcky I'll do that! Thank you for picking these issues. |
-Proofread, checked all links and references
-Updated maths to style guide
-Added a few comments to solve questions I had while reading the document