Skip to content

Attributes are now carried over during conversion. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2025
Merged

Attributes are now carried over during conversion. #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33e2492
Attributes are now carried over during conversion.
nestenes Aug 23, 2022
febf262
Removed line whitespace as indicated by luacheck
nestenes Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified buildPlugin.rbxl
View file
Open in desktop
Binary file not shown.
8 changes: 6 additions & 2 deletions src/Converter.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ Converter.SearchCache = false -- TODO: Try enabling cache
Converter.ServiceNameMap = setmetatable({}, {
__index = function(self, className)
local isService = className:find("Service$")
or className:find("Provider$")
or className:find("Settings$")
or className:find("Provider$")
or className:find("Settings$")

if not isService then
-- Try to find the service
Expand Down Expand Up @@ -545,6 +545,10 @@ function Converter:ChangeClass(object, ClassName)
for _, Tag in pairs(CollectionService:GetTags(object)) do
CollectionService:AddTag(newObject, Tag)
end
-- Attribute instance
for AttributeName, AttributeValue in pairs(object:GetAttributes()) do
newObject:SetAttribute(AttributeName, AttributeValue)
end

-- Go through each child and identify properties that point towards the parent that's getting replaced
local oldParent = object.Parent
Expand Down