feat: refactor build configuration #7748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is imported internally but can still be overridden should someone be doing that
we only need to provide default inputs when none are provided
also remove the workaround that we needed in core for chunk filenames
we don't have a qrl mapping in dev because there's no manifest, so instead we make parseable qrl segment filenames
- saner default input handling - do not write q-manifest to temp dir - try reading manifest on every platform that has the `node:fs` module
🦋 Changeset detectedLatest commit: b1aaee4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
note that the previous commits unblocked full SSG for docs
wmertens
force-pushed
the
v2-router-things
branch
from
749bb07 to
6839612
Compare
wmertens
force-pushed
the
v2-router-things
branch
from
6839612 to
b1aaee4
Compare
There was a problem hiding this comment.
Pull Request Overview
This is a comprehensive refactoring of the build configuration for Qwik applications that removes the deprecated useQwikRouter functionality and introduces several key improvements to the build system. The refactoring focuses on simplifying the build process, improving SSG (Static Site Generation) capabilities, and streamlining router configuration.
- Removal of
qwikRouterConfigparameter from router creation, making it automatically resolved - Renaming of Static Site Generation from "static" to "ssg" for better clarity
- Simplification of build input handling and manifest management in the Vite plugin
Reviewed Changes
Copilot reviewed 147 out of 156 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| starters/dev-server.ts | Removes qwikRouterConfig import and parameter from router creation |
| starters/apps//src/entry..tsx | Updates all starter app entry points to remove qwikRouterConfig |
| packages/qwik-router/src/ssg/ | Renames and refactors static generation from "static" to "ssg" |
| packages/qwik/src/optimizer/src/plugins/vite.ts | Major refactoring of build configuration and input handling |
| packages/qwik/src/server/platform.ts | Improves dev mode symbol mapping |
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the unnecessary qwikRouterConfig prop drilling, and make trailingSlash a build constant, clean up vite config normalization, clean up entry file provisioning, try harder to find client manifest in ssr build, and move dev qrl symbolMapper into core.
Also, rename the /static in router to /ssg so that it's clearer what it's for