Fix duplicate export handling in _create_synthetic_qsegment function

[Copilot]

Problem

The _create_synthetic_qsegment function in the Qwik optimizer had duplicate export handling logic that was causing inconsistent behavior:

1. First export handling block - ran unconditionally for all local_idents
2. Second export handling block - ran only when should_emit was true

This duplication meant that exports were being ensured twice in some cases, and the logic was inconsistent about when exports should be generated.

Solution

Refactored the function to consolidate export handling into a single block at the end of the function, after all processing (including deep recursion) is complete. The key insights were:

• Deep recursion already works correctly - the function properly discovers all embedded QRL segments through first_arg.fold_with(self)
• Exports need to be ensured when segments are created - regardless of the outer segment's should_emit status, because nested segments created during recursion need access to their dependencies
• Single point of export handling - eliminates duplication and ensures consistent behavior

Changes

• Removed the first (unconditional) export handling block
• Consolidated all export handling logic at the end of the function
• Added comprehensive comments explaining the reasoning
• Maintained the same export conditions but applied them consistently

Testing

• All existing tests pass (140/140)
• Specifically fixes the example_drop_side_effects test that was failing due to missing exports
• No behavioral changes for correctly working cases - only fixes the inconsistent duplicate handling

The fix ensures that export handling happens at the proper time (after deep recursion discovers all segments) while maintaining the correct conditions for when exports should be generated.

Created from VS Code via the GitHub Pull Request extension.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 9e87449

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR