-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: introduce deferUpdates option for useTask$ #8107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 0782caa The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
|
now that I read it again, Maybe just |
wmertens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
three thumbs up, LGTM except maybe the option name
|
Maybe it would be nice to include a description which says that useTask will always block rendering when executed on server. This option is only for browser |
changed to deferUpdates after talking to Jack |
|
We need to talk about this change if it should be default to match v1 behavior. |
|
We decided that the v1 blocking behavior should stand and we need to enable non-blocking via an option. The alternative is creating a Promise but not returning it, but that doesn't feel great so the option is still useful |
2ed2983 to
20f1f3d
Compare
gioboa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks awesome to me ✅🙏
|
I'd like to rename the option to something that needs to be set to |
20f1f3d to
4460b3a
Compare
wmertens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ec56c4d to
0782caa
Compare

Add new option for useTask$
blockRender. It helps managing animations and view transitions