Skip to content

Conversation

@Varixo
Copy link
Member

@Varixo Varixo commented Nov 9, 2025

Skip applying journal during diffing or component execution to prevent flickering

@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2025

⚠️ No Changeset found

Latest commit: 07deb2c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Varixo Varixo force-pushed the v2-skip-journal-during-diff branch from 2e40544 to 740101b Compare November 9, 2025 17:09
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 07deb2c

@Varixo Varixo force-pushed the v2-skip-journal-during-diff branch 3 times, most recently from 623287d to a21e92b Compare November 9, 2025 18:01
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 9, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8143
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8143
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8143
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8143

commit: 07deb2c

@Varixo Varixo force-pushed the v2-skip-journal-during-diff branch from a21e92b to 07deb2c Compare November 12, 2025 15:05
@Varixo Varixo marked this pull request as ready for review November 12, 2025 15:29
@Varixo Varixo requested a review from a team as a code owner November 12, 2025 15:29
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 0ad6748 into build/v2 Nov 12, 2025
37 of 40 checks passed
@wmertens wmertens deleted the v2-skip-journal-during-diff branch November 12, 2025 16:41
@Varixo Varixo self-assigned this Nov 12, 2025
@Varixo Varixo moved this from Backlog to Done in Qwik Development Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants