Skip to content

Conversation

@Varixo
Copy link
Member

@Varixo Varixo commented Nov 9, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2025

⚠️ No Changeset found

Latest commit: 94df210

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 9, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8144
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8144
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8144
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8144

commit: 94df210

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 1408c0a

@wmertens
Copy link
Member

Not sure if we should put it in a global - qwikloader can maintain its own?

Also, if we just memoize the chunk imports and then get the symbol from those, we maintain a smaller object.

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Varixo Varixo moved this from Backlog to Waiting For Review in Qwik Development Nov 10, 2025
@Varixo Varixo marked this pull request as ready for review November 10, 2025 12:00
@Varixo Varixo requested a review from a team as a code owner November 10, 2025 12:00
@Varixo Varixo force-pushed the v2-qrls-memoizing branch 2 times, most recently from 79d94b5 to 94df210 Compare November 10, 2025 12:22
@Varixo Varixo merged commit 2110331 into build/v2 Nov 10, 2025
20 checks passed
@Varixo Varixo deleted the v2-qrls-memoizing branch November 10, 2025 14:15
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants