- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2.1k
tests: call gnrc_ipv6_nib_iface_up() after gnrc_ipv6_nib_init_iface() #18635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: call gnrc_ipv6_nib_iface_up() after gnrc_ipv6_nib_init_iface() #18635
Conversation
| gnrc_netif_acquire(_mock_netif); | ||
| gnrc_ipv6_nib_init_iface(_mock_netif); | ||
| gnrc_netif_release(_mock_netif); | ||
| gnrc_ipv6_nib_iface_up(_mock_netif); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gnrc_ipv6_nib_init()/gnrc_ipv6_nib_iface_up() will both call gnrc_netif_acquire() - no need to do it here.
| For me, with  What is with  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to find out the reason, why it is not failing on native (might be pointing to a bug), but for now, let's just get the tests working again.
1a160c0    to
    d2e57ac      
    Compare
  
    | Does it work on some board for you, or do you also get some weird python output? | 
| Huh what weird Python output are you getting and from what? | 
| 
 
 thisBut if it does not happen for you, it is my python probably | 
| 
 Removed the USB cable and put it back in, now it runs ... | 
| Seems more like some synchronization issues between the node and the host serial ;-). | 
Contribution description
We now have to call
gnrc_ipv6_nib_iface_up()to configure addresses / start ARSM after callinggnrc_ipv6_nib_init_iface()Testing procedure
Run the tests on a board. For some reason this is not failing on
nativewithout the patch, but does on e.g.samd20-xpro.Issues/PRs references
#17893 (comment)